request a code review #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aplicacion vitejs
feat: i do typescript type
feat: I add formatMovie function and unit testing
Fix: unit testing and formatMovie
continudad del H U 2
feat: MovieList
feat: add Home component
feat> add css to moviecard, movielist and app
feat: add more style
feat: add unit testing for MovieCard
feat: add unit testing for MovieList
feat: add update of get movies to pagination
feat: i start pagination component
feat: finish pagination component
feat: add getMovieGenres
feat: add a unit testing for paginanation component
feat: add formatGenresToMap
fix: filter by
feat: i start movieDetail component
feat: add the last component (movie detail)
fix: unit testing
fix: unit testing
fix: movie detail test
feat: (readme)i change readme
Update README.md
reloadercf
approved these changes
Jun 5, 2024
| <html lang="en"> | ||
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <link rel="icon" type="image/svg+xml" href="/vite.svg" /> |
| }, | ||
| "dependencies": { | ||
| "dotenv": "^16.4.5", | ||
| "jsdom": "^24.1.0", |
Comment on lines
+7
to
+12
| <link rel="preconnect" href="https://fonts.googleapis.com" /> | ||
| <link rel="preconnect" href="https://fonts.gstatic.com" crossorigin /> | ||
| <link | ||
| href="https://fonts.googleapis.com/css2?family=Lexend:[email protected]&display=swap" | ||
| rel="stylesheet" | ||
| /> |
There was a problem hiding this comment.
Maybe you can move the fonts to style.css
<style> @import url('https://fonts.googleapis.com/css2?family=Roboto:ital,wght@0,100;0,300;0,400;0,500;0,700;0,900;1,100;1,300;1,400;1,500;1,700;1,900&display=swap'); </style>| "react-dom": "^18.2.0", | ||
| "react-loading": "^2.0.3", | ||
| "react-router-dom": "^6.23.0", | ||
| "vitest": "^1.6.0" |
Comment on lines
+3
to
+4
| import Home from "./components/Home"; | ||
| import { MovieDetail } from "./components/MovieDetail"; |
There was a problem hiding this comment.
Suggested change
| import Home from "./components/Home"; | |
| import { MovieDetail } from "./components/MovieDetail"; | |
| import Home from "./components/Home"; | |
| import MovieDetail from "./components/MovieDetail"; |
consistency
| ]; | ||
|
|
||
| setTimeout(() => { | ||
| expect(getByText(moviesExpected[0].title)).toBeInTheDocument(); |
| id="seletFilter" | ||
| value={selectedOption?.value || ""} | ||
| onChange={(event) => { | ||
| const selectedOption = options.find(option => option.value === event.target.value); |
| @@ -0,0 +1,10 @@ | |||
| import React from 'react' | |||
There was a problem hiding this comment.
In the future try install eslint and prettier
Comment on lines
+6
to
+20
| export function getMovieGenres(): Promise<[{ id: number; name: string }]> { | ||
| return fetch(`https://api.themoviedb.org/3/genre/movie/list?language=en`, { | ||
| method: "GET", | ||
| headers: { | ||
| accept: "application/json", | ||
| Authorization: `Bearer ${token}`, | ||
| }, | ||
| }) | ||
| .then((response) => response.json()) | ||
| .then((genresResult) => { | ||
| return genresResult.genres; | ||
| }) | ||
| .catch((error) => { | ||
| throw error; | ||
| }); |
Update README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.