Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start moving some utils out of Perseus #2088

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Conversation

handeyeco
Copy link
Contributor

@handeyeco handeyeco commented Jan 9, 2025

Summary:

One of a few PRs where I'll be moving utils we need on the server out of perseus and into perseus-core

Issue: LEMS-2737

@handeyeco handeyeco self-assigned this Jan 9, 2025
@handeyeco handeyeco changed the title move objective_ Start moving some utils out of Perseus Jan 9, 2025
Copy link
Contributor

github-actions bot commented Jan 9, 2025

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (eeb12cb) and published it to npm. You
can install it using the tag PR2088.

Example:

yarn add @khanacademy/perseus@PR2088

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR2088

Copy link
Contributor

github-actions bot commented Jan 9, 2025

Size Change: +18.6 kB (+1.29%)

Total Size: 1.47 MB

Filename Size Change
packages/perseus-core/dist/es/index.js 23 kB +19 kB (+473.29%) 🆘
packages/perseus/dist/es/index.js 410 kB -329 B (-0.08%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 39 kB
packages/keypad-context/dist/es/index.js 760 B
packages/kmath/dist/es/index.js 83.1 kB
packages/math-input/dist/es/index.js 78 kB
packages/math-input/dist/es/strings.js 1.79 kB
packages/perseus-editor/dist/es/index.js 688 kB
packages/perseus-linter/dist/es/index.js 22.2 kB
packages/perseus-score/dist/es/index.js 103 kB
packages/perseus/dist/es/strings.js 4.82 kB
packages/pure-markdown/dist/es/index.js 3.67 kB
packages/simple-markdown/dist/es/index.js 12.5 kB

compressed-size-action

@handeyeco handeyeco requested review from a team January 9, 2025 20:49
@@ -1,9 +0,0 @@
// Performs a deep copy of the given object. If there are cycles in the object
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not certain we want to move this into Perseus-core. It's only used in tests. Also, if we want to do this move, I'd want to see if we can consolidate all the different ways we clone (today, we have this clone, then we have deepClone(), another clone(), and _.clone(): all of which look to do very similar things).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a total mistake from me being on auto-pilot. Thanks for catching it.

Base automatically changed from make-perseus-score to main January 10, 2025 19:16
@handeyeco
Copy link
Contributor Author

The parent pull-request (#2086) has been merged into main, but this branch (LEMS-2737-2/utils) now has conflicts with the new base branch. These conflicts must be resolved before checks can complete on this pull-request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants