-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start moving some utils out of Perseus #2088
base: main
Are you sure you want to change the base?
Conversation
… perseus-score, move perseus-types in perseus to data-schema in perseus-core
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (eeb12cb) and published it to npm. You Example: yarn add @khanacademy/perseus@PR2088 If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR2088 |
Size Change: +18.6 kB (+1.29%) Total Size: 1.47 MB
ℹ️ View Unchanged
|
testing/object-utils.ts
Outdated
@@ -1,9 +0,0 @@ | |||
// Performs a deep copy of the given object. If there are cycles in the object |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not certain we want to move this into Perseus-core
. It's only used in tests. Also, if we want to do this move, I'd want to see if we can consolidate all the different ways we clone (today, we have this clone
, then we have deepClone()
, another clone()
, and _.clone()
: all of which look to do very similar things).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a total mistake from me being on auto-pilot. Thanks for catching it.
The parent pull-request (#2086) has been merged into |
Summary:
One of a few PRs where I'll be moving utils we need on the server out of
perseus
and intoperseus-core
Issue: LEMS-2737