feat: add language localization support for converting numbers to loc… #1359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
KevinVandy
reviewed
Jan 9, 2025
| @@ -1,6 +1,7 @@ | |||
| import { type MRT_Localization } from '..'; | |||
|
|
|||
| export const MRT_Localization_EN: MRT_Localization = { | |||
| language: 'en', | |||
There was a problem hiding this comment.
we would need to add this to every single locale, right?
There was a problem hiding this comment.
yes this would be the implication. I have some capacity to do this on the weekend.
If we make the property optional and do not specify it the formatting would default to the browser language
…al string This explicitly tells the `toLocaleString` function which language to use based on the provided localization instead of relying on the browser language. This allows a correct formatting of numbers within a multi language app.
fredericbahr
force-pushed
the
language-flag-formatting
branch
from
318cdc2 to
5775e2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…al string
This explicitly tells the
toLocaleStringfunction which language to use based on the provided localization instead of relying on the browser language. This allows a correct formatting of numbers within a multi language app.This is a Proof of Concept implementation of #1331.
If you are confirm with it, i am more than happy to apply the language property to all locales and add proper documentation.
Thanks in advance, i am really looking forward for this feature