Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llvm*: Fix rubocop 1.70.0 violations #203969

Merged
merged 9 commits into from
Jan 12, 2025
Merged

Conversation

dduugg
Copy link
Member

@dduugg dduugg commented Jan 12, 2025

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Unblocks Homebrew/brew#19070
See https://github.com/Homebrew/brew/actions/runs/12719435273/job/35459670049?pr=19070

@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Jan 12, 2025
@dduugg dduugg changed the title llvm: Fix rubocop 1.70.0 violations llvm*: Fix rubocop 1.70.0 violations Jan 12, 2025
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Jan 12, 2025
@dduugg dduugg force-pushed the rubocop-fixes-llvm branch from a663e6b to 3a014b8 Compare January 12, 2025 03:02
@github-actions github-actions bot removed the automerge-skip `brew pr-automerge` will skip this pull request label Jan 12, 2025
Formula/l/llvm.rb Outdated Show resolved Hide resolved
@carlocab carlocab added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Jan 12, 2025
@dduugg dduugg force-pushed the rubocop-fixes-llvm branch from 3a014b8 to 8be4c09 Compare January 12, 2025 16:30
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Jan 12, 2025
@dduugg dduugg force-pushed the rubocop-fixes-llvm branch from 8be4c09 to 51e9c3f Compare January 12, 2025 16:44
@dduugg dduugg force-pushed the rubocop-fixes-llvm branch from 51e9c3f to 9b72408 Compare January 12, 2025 16:59
@carlocab carlocab added this pull request to the merge queue Jan 12, 2025
Merged via the queue into Homebrew:master with commit ac68f18 Jan 12, 2025
17 checks passed
@dduugg dduugg deleted the rubocop-fixes-llvm branch January 12, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants