Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moneymoney 2.4.48 url #197938

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

moneymoney 2.4.48 url #197938

wants to merge 1 commit into from

Conversation

rlpvin
Copy link
Contributor

@rlpvin rlpvin commented Jan 11, 2025

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

Related to: #172732 (comment)

Copy link
Member

@daeho-ro daeho-ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous link is also working but the homepage uses the package url and so I think it is worth to change it.

@@ -2,7 +2,7 @@
version "2.4.48"
sha256 :no_check

url "https://service.moneymoney-app.com/1/MoneyMoney.zip"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous url is the one provided by the vendor's sparkle feed, which is used by livecheck. I think it is ok to leave the existing method, as it aligns more closer with the updates, unless there is a specific reason that the pkg works better as an installer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants