Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude some stdlib gems from RBI generation #19075

Merged
merged 4 commits into from
Jan 13, 2025

Conversation

dduugg
Copy link
Member

@dduugg dduugg commented Jan 11, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

I propose excluding stdlib gems whose rbi files are already provided by sorbet: https://github.com/sorbet/sorbet/tree/master/rbi/stdlib

This saves some git bloat, and the sorbet versions are mostly better (they often include stricter type definitions, though AFAIK they are not automatically updated when new gem versions are released).

@dduugg dduugg force-pushed the no-stdlib-rbi-generation branch 2 times, most recently from ff6fdf4 to 5fa0348 Compare January 12, 2025 18:09
@dduugg dduugg force-pushed the no-stdlib-rbi-generation branch from 0ea8c6e to 4ecfca5 Compare January 12, 2025 18:51
@dduugg dduugg force-pushed the no-stdlib-rbi-generation branch from 4ecfca5 to 64c45d4 Compare January 12, 2025 18:59
Copy link

@timscharfenort8 timscharfenort8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks @dduugg!

@MikeMcQuaid MikeMcQuaid enabled auto-merge January 13, 2025 09:06
@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Jan 13, 2025
Merged via the queue into master with commit fa45414 Jan 13, 2025
29 checks passed
@MikeMcQuaid MikeMcQuaid deleted the no-stdlib-rbi-generation branch January 13, 2025 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants