Allow Closing to detect dependent resources passed as kwargs too #636 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
federinik
force-pushed
the
master
branch
3 times, most recently
from
7195cbd to
f3d7e68
Compare
|
Hi @jazzthief, PR created! Sorry for the mess with the force pushes, my email was misconfigurated and had to redo the commits, hope everything is fine now. |
|
@federinik No problem at all, good job and thanks for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small addiction to the work of @StummeJ about issue ets-labs#633 which allows to benefit of his improvement even for dependencies passed as kwargs (such as my case)
UPDATE: integrated with @jazzthief PR ets-labs#711