Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not advertize fortran order for cubical #77

Conversation

VincentRouvreau
Copy link
Contributor

Should help users for issues like GUDHI/gudhi-devel#1162

Also minor change:

  • shade=True will be deprecated for seaborn 0.14, use fill=True instead

…ated for seaborn 0.14, use fill=True instead
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@mglisse mglisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. Ideally we would use non-square matrices so we can plot and check if it looks ok, but that's less important.

@VincentRouvreau VincentRouvreau merged commit 706e950 into GUDHI:master Dec 20, 2024
1 check passed
@VincentRouvreau VincentRouvreau deleted the do_not_advertize_fortran_order_for_cubical branch December 20, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants