Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated code to allow sidenav expand on click #2256

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

alexjanousekGSA
Copy link
Contributor

@alexjanousekGSA alexjanousekGSA commented Jan 9, 2025

Navbar improvements

  • When clicking on About Notify, a subnav will now open that maintains style consistency with its parent links.
  • Header navbar is updated with active state when sublinks are clicked.
  • This overrides uswds default components
image

@alexjanousekGSA
Copy link
Contributor Author

image The changes made here to allow a larger width for the sidenav affected all sidenavs globally and pushed content to the side. BackstopJS highlighted this well and we are discussing now if we will keep the width or make it a case by case basis. In this specific screenshot you can see some content needs a slight update to fit in the smaller space.

@alexjanousekGSA alexjanousekGSA self-assigned this Jan 12, 2025
@alexjanousekGSA alexjanousekGSA linked an issue Jan 12, 2025 that may be closed by this pull request
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

Update nav for production release
1 participant