Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove author landing page and metadata (EPIC) #8216

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

nick-mon1
Copy link
Contributor

@nick-mon1 nick-mon1 commented Nov 26, 2024

Summary

Removes author metadata and redirects https://digital.gov/authors/ to https://digital.gov/news.

This PR covers:

  • redirects /authors to /news
  • removes some bio fields from the author template

Fields to Keep

  • display_name
  • first_name
  • last_name
  • slug
  • agency
  • photo (custom photo path)
  • github (github name for image)

The below PR's will be merged into this PR covers the removal of author metadata.

PR Description
8217 Removes authors A-B
8256 Removes authors B-C

Preview

Link to Preview

Solution

Provide a summary of the solution this PR offers.

How To Test

  1. First Step
  2. Second Step
  3. Third Step

Copy link

🔍 Preview in Federalist

@nick-mon1 nick-mon1 changed the title Remove author landing page and metadata Remove author landing page and metadata (EPIC) Nov 27, 2024
@camillemorrow camillemorrow marked this pull request as ready for review December 9, 2024 14:33
camillemorrow
camillemorrow previously approved these changes Dec 9, 2024
Copy link
Contributor

@bonnieAcameron bonnieAcameron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some bits and pieces of metadata or helper text that I've flagged for removal. Although I have only flagged them in 1-2 places, they actually appear throughout the 2 sub-PRs. Some metadata still contains PII.

I also have a question about the consistency of the agency field, whether it is acronym only or spelled out (I suggest the latter, but I want to make sure that it is a proactive decision)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants