Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Turning addon #268

Closed
wants to merge 5 commits into from
Closed

Conversation

dubstar-04
Copy link

No description provided.

@dubstar-04
Copy link
Author

Will the addon manager resolve submodules included in addons?

@luzpaz
Copy link
Collaborator

luzpaz commented Aug 7, 2023

We just prefer to add the submodules on our end.

@luzpaz
Copy link
Collaborator

luzpaz commented Aug 9, 2023

We can add manually, no worries. Is this PR ready ?

@dubstar-04
Copy link
Author

I would prefer to hold the PR. I've made some significant improvements to the code and it would be best if I released a video explaining how to use the add-on.

The Add-on includes a submodule for liblathe. I was hoping that the addon manager would resolve the submodule itself then I could release new addon versions as I develop liblathe.

@luzpaz
Copy link
Collaborator

luzpaz commented Aug 9, 2023

is liblathe on pypi ?

@chennes what is the addon manager policy on including submodules inside addons? Do we prefer to have them approved and added to https://github.com/FreeCAD/FreeCAD-addons/blob/master/ALLOWED_PYTHON_PACKAGES.txt ?

@dubstar-04
Copy link
Author

Liblathe isn't currently published on pypi but there is a script to automate publishing: https://github.com/dubstar-04/LibLathe/blob/master/publish.py

I can publish it if required.

Are approved pypi modules automatically downloaded and updated with the associated addon?

@dubstar-04
Copy link
Author

Alternatively I can create a separate addon for liblathe?

@chennes
Copy link
Member

chennes commented Aug 9, 2023

If your module is available via PyPi then the Addon Manager can automatically install it. The same is true if you make it a FreeCAD Addon. There is a file in this repo that contains an AllowList for PyPi packages that we would need to add it to.

@dubstar-04
Copy link
Author

Thanks for the reply. Please leave this PR draft and I will let you know when it's ready. I'm on vacation this week but hopefully find time next week.

@chennes
Copy link
Member

chennes commented Jan 5, 2024

@dubstar-04 is there any update on this?

@dubstar-04
Copy link
Author

I created a PyPi package for liblathe. That appears to install and work as expected, however I don't have time to finish the work at the moment. I will closed this PR.

@dubstar-04 dubstar-04 closed this Jan 5, 2024
@dubstar-04 dubstar-04 reopened this Jan 5, 2025
@dubstar-04
Copy link
Author

How does the addon manager handle pypi packages? will it always install the latest or can I include a version number?

@luzpaz
Copy link
Collaborator

luzpaz commented Jan 5, 2025

@dubstar-04 per the package.xml1 docs
AddonManager will always pull the latest version. But there are attributes that you can leverage.
For example

    <depend version_gte="VERSION">dependency</depend>

gte: greater than or equal to

Footnotes

  1. https://wiki.freecad.org/Package_Metadata#.3Cdepend.3E

@dubstar-04
Copy link
Author

@luzpaz that's brilliant thank you. Not sure why I missed it.

@dubstar-04 dubstar-04 force-pushed the FreeCAD-Turning-Addon branch from f37ac30 to 2e6e458 Compare January 6, 2025 12:05
@dubstar-04 dubstar-04 closed this Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants