-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Turning addon #268
Add Turning addon #268
Conversation
Will the addon manager resolve submodules included in addons? |
We just prefer to add the submodules on our end. |
We can add manually, no worries. Is this PR ready ? |
I would prefer to hold the PR. I've made some significant improvements to the code and it would be best if I released a video explaining how to use the add-on. The Add-on includes a submodule for liblathe. I was hoping that the addon manager would resolve the submodule itself then I could release new addon versions as I develop liblathe. |
is liblathe on pypi ? @chennes what is the addon manager policy on including submodules inside addons? Do we prefer to have them approved and added to https://github.com/FreeCAD/FreeCAD-addons/blob/master/ALLOWED_PYTHON_PACKAGES.txt ? |
Liblathe isn't currently published on pypi but there is a script to automate publishing: https://github.com/dubstar-04/LibLathe/blob/master/publish.py I can publish it if required. Are approved pypi modules automatically downloaded and updated with the associated addon? |
Alternatively I can create a separate addon for liblathe? |
If your module is available via PyPi then the Addon Manager can automatically install it. The same is true if you make it a FreeCAD Addon. There is a file in this repo that contains an AllowList for PyPi packages that we would need to add it to. |
Thanks for the reply. Please leave this PR draft and I will let you know when it's ready. I'm on vacation this week but hopefully find time next week. |
@dubstar-04 is there any update on this? |
I created a PyPi package for liblathe. That appears to install and work as expected, however I don't have time to finish the work at the moment. I will closed this PR. |
How does the addon manager handle pypi packages? will it always install the latest or can I include a version number? |
@dubstar-04 per the package.xml1 docs
Footnotes |
@luzpaz that's brilliant thank you. Not sure why I missed it. |
f37ac30
to
2e6e458
Compare
No description provided.