-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A shared folder structure #102
Draft
eric-burel
wants to merge
1
commit into
main
Choose a base branch
from
feature/isolate-scripts
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for stateofcss2021 failed.
|
❌ Deploy Preview for stateofjs2021 failed.
|
✅ Deploy Preview for state-of-graphql canceled.
|
✅ Deploy Preview for devographics-static canceled.
|
✅ Deploy Preview for stateofjs canceled.
|
❌ Deploy Preview for stateofgraphql2022 failed.
|
✅ Deploy Preview for devographics-graphiql-internal canceled.
|
✅ Deploy Preview for stateofcss canceled.
|
✅ Deploy Preview for graphiql-devographics canceled.
|
Gatsby Cloud Build Report🚩 Your build failed. See the build logs here |
1 similar comment
Gatsby Cloud Build Report🚩 Your build failed. See the build logs here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Idea:
I need to dig the experimental "externalDir" of Next.js:
I'd like to avoid as much as possible a full-fledged monorepo, because they are simply hard to setup. But maybe I am wrong, pnpm workspaces are worth investigating.
Anyway for a first version I am trying to stick with file imports. "shared" is simply a code folder, but outside of the actual app because it's used by multiple app. The "shared/package.json" is just there for development, the main app must make sure that it also includes the right dependencies, because only its package.json will be actually used during build/run.
The only other alternative is to make the Next.js app "fat" and keep scripts there, a bit like Meteor used to work.
Use cases
Resources