Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dotnet] fix annotation for DD_TRACE_ENABLED remote config test #3869

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lucaspimentel
Copy link
Member

@lucaspimentel lucaspimentel commented Jan 21, 2025

Motivation

This is not a bug.

Changes

Fix the annotation for this test. This test was disabled in #2962 (Jira ticket was added in #3371). The test broke with the update to .NET tracing library 3.x.

tests/parametric/test_dynamic_configuration.py::TestDynamicConfigTracingEnabled::test_tracing_client_tracing_disable_one_way

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@lucaspimentel lucaspimentel added dotnet Pull requests that update .NET code run-parametric-scenario labels Jan 21, 2025
@lucaspimentel lucaspimentel changed the title [dotnet] revert disabling test for DD_TRACE_ENABLED [dotnet] re-enable test for DD_TRACE_ENABLED Jan 21, 2025
@lucaspimentel lucaspimentel force-pushed the lpimentel/dotnet-dd-trace-enabled branch from b9134a7 to 0a261e5 Compare January 25, 2025 00:09
@lucaspimentel lucaspimentel changed the title [dotnet] re-enable test for DD_TRACE_ENABLED [dotnet] fix annotation for DD_TRACE_ENABLED remote config test Jan 25, 2025
@lucaspimentel lucaspimentel force-pushed the lpimentel/dotnet-dd-trace-enabled branch from 0a261e5 to 71e5880 Compare January 25, 2025 00:14
@lucaspimentel lucaspimentel marked this pull request as ready for review January 25, 2025 00:14
@lucaspimentel lucaspimentel requested review from mabdinur and a team as code owners January 25, 2025 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dotnet Pull requests that update .NET code run-parametric-scenario
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant