-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LFI endpoint for php #2966
Draft
estringana
wants to merge
8
commits into
main
Choose a base branch
from
estringana/add-lfi-to-php
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add LFI endpoint for php #2966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estringana
force-pushed
the
estringana/add-lfi-to-php
branch
from
September 4, 2024 07:47
12786ac
to
9a58363
Compare
estringana
force-pushed
the
estringana/add-lfi-to-php
branch
from
September 16, 2024 08:14
2505241
to
518d22e
Compare
cbeauchesne
requested changes
Sep 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is failing
estringana
force-pushed
the
estringana/add-lfi-to-php
branch
from
December 13, 2024 08:52
518d22e
to
55b4451
Compare
estringana
force-pushed
the
estringana/add-lfi-to-php
branch
from
December 16, 2024 13:45
346ab01
to
dd81cf1
Compare
estringana
force-pushed
the
estringana/add-lfi-to-php
branch
5 times, most recently
from
December 23, 2024 12:04
212fb48
to
1f90685
Compare
estringana
force-pushed
the
estringana/add-lfi-to-php
branch
from
January 23, 2025 12:19
64cb57a
to
8a37d49
Compare
estringana
force-pushed
the
estringana/add-lfi-to-php
branch
from
January 24, 2025 16:54
7dccdaf
to
de39e5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
LFI endpoint on PHP was empty. This PR implements the expected behaviour of this endpoint. It also enables all lfi tests.
APPSEC-52934
Changes
Workflow
codeowners
file quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>]
, double-check that only<language>
is impacted by the changebuild-XXX-image
label is present