Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LFI endpoint for php #2966

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Add LFI endpoint for php #2966

wants to merge 8 commits into from

Conversation

estringana
Copy link
Contributor

Motivation

LFI endpoint on PHP was empty. This PR implements the expected behaviour of this endpoint. It also enables all lfi tests.

APPSEC-52934

Changes

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@estringana estringana force-pushed the estringana/add-lfi-to-php branch from 12786ac to 9a58363 Compare September 4, 2024 07:47
@estringana estringana force-pushed the estringana/add-lfi-to-php branch from 2505241 to 518d22e Compare September 16, 2024 08:14
@estringana estringana marked this pull request as ready for review September 16, 2024 08:14
@estringana estringana requested review from a team as code owners September 16, 2024 08:14
Copy link
Collaborator

@cbeauchesne cbeauchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing

@estringana estringana force-pushed the estringana/add-lfi-to-php branch from 518d22e to 55b4451 Compare December 13, 2024 08:52
@cbeauchesne cbeauchesne marked this pull request as draft December 13, 2024 13:46
@estringana estringana force-pushed the estringana/add-lfi-to-php branch from 346ab01 to dd81cf1 Compare December 16, 2024 13:45
@estringana estringana force-pushed the estringana/add-lfi-to-php branch 5 times, most recently from 212fb48 to 1f90685 Compare December 23, 2024 12:04
@estringana estringana force-pushed the estringana/add-lfi-to-php branch from 64cb57a to 8a37d49 Compare January 23, 2025 12:19
@estringana estringana force-pushed the estringana/add-lfi-to-php branch from 7dccdaf to de39e5d Compare January 24, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants