Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AI-4814] DDSaaS: Silverstripe CMS: Integration v1.0.0 #19364

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

narendranandaniya-crest
Copy link
Contributor

What does this PR do?

  • PR for a new integration Silverstripe CMS 1.0.0

Additional Notes

  • The assets are available in our sandbox and can be shared separately with the required teams.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 83.55438% with 62 lines in your changes missing coverage. Please review.

Project coverage is 87.89%. Comparing base (edf5718) to head (1ba3a61).
Report is 63 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
silverstripe_cms 83.55% <83.55%> (?)
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@narendranandaniya-crest narendranandaniya-crest marked this pull request as ready for review January 13, 2025 09:30
@narendranandaniya-crest narendranandaniya-crest changed the title DDSaaS: Silverstripe CMS: Integration v1.0.0 [AI-4814] DDSaaS: Silverstripe CMS: Integration v1.0.0 Jan 13, 2025
@rtrieu rtrieu added the editorial review Waiting on a more in-depth review from a docs team editor label Jan 13, 2025
@rtrieu
Copy link
Contributor

rtrieu commented Jan 13, 2025

Created DOCS-9854 for docs review.

Copy link
Contributor

@iliakur iliakur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick comment on the changelogs. This should not happen if you're using the ddev create templates...
We'll review the implementation and tests later.

# (C) Datadog, Inc. 2025-present
# All rights reserved
# Licensed under a 3-clause BSD style license (see LICENSE)
__version__ = "1.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
__version__ = "1.0.0"
__version__ = "0.0.1"

Comment on lines +5 to +9
## 1.0.0 / 2024-12-27

***Added***:

* Initial Release
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## 1.0.0 / 2024-12-27
***Added***:
* Initial Release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants