Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AI-4795 Coverage for ray_vllm* metrics #19358

Open
wants to merge 23 commits into
base: master
Choose a base branch
from

Conversation

UTXOnly
Copy link
Contributor

@UTXOnly UTXOnly commented Jan 8, 2025

What does this PR do?

  • Adds coverage for metrics prefixed with ray_vllm: for when vllm is run as a library
  • Adds unit tests to ensure ray_vllm: metrics are collected

Motivation

Review checklist (to be filled by reviewers)

  • [] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • [] Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link

github-actions bot commented Jan 9, 2025

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

Copy link

github-actions bot commented Jan 9, 2025

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

Copy link

github-actions bot commented Jan 9, 2025

The changelog type changed or removed was used in this Pull Request, so the next release will bump major version. Please make sure this is a breaking change, or use the fixed or added type instead.

@UTXOnly UTXOnly marked this pull request as ready for review January 9, 2025 16:22
@UTXOnly UTXOnly requested a review from a team as a code owner January 9, 2025 16:22
vllm/changelog.d/19358.added Outdated Show resolved Hide resolved
@UTXOnly UTXOnly requested a review from Kyle-Neale January 9, 2025 17:07
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.93%. Comparing base (0ec4af3) to head (d2d5909).
Report is 2 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?
vllm 94.44% <100.00%> (+1.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants