Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI Visibility] Add CI provider name to custom pipeline example #27021

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rodrigo-roca
Copy link
Contributor

@rodrigo-roca rodrigo-roca commented Jan 8, 2025

What does this PR do? What is the motivation?

We added a new field called provider_name which will allow customers to specify the provider name. Up until now we always used custom. There will be another PR for the API spec

Merge instructions

Merge readiness:

  • Ready for merge

Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the <yourname>/description naming convention) and then add the following PR comment:

/merge

Additional notes

@rodrigo-roca rodrigo-roca changed the title add provider name [CI Visibility] Add CI provider name to custom pipeline example Jan 8, 2025
@rodrigo-roca rodrigo-roca marked this pull request as ready for review January 8, 2025 11:36
@rodrigo-roca rodrigo-roca requested review from a team as code owners January 8, 2025 11:36
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Preview links (active after the build_preview check completes)

Modified Files

Copy link
Contributor

@buraizu buraizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting a minor update for consistency with how other placeholder values are listed in this doc, and also per the documentation style guide

content/en/continuous_integration/pipelines/custom.md Outdated Show resolved Hide resolved
@rodrigo-roca rodrigo-roca requested a review from buraizu January 9, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants