-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish via Trusted Publishing #4315
base: master
Are you sure you want to change the base?
Conversation
steps: | ||
- name: Download from RubyGems | ||
run: | | ||
gem fetch datadog --version ${GEM_VERSION} --verbose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it wait for gem presence? Sometimes it's not immediately available because - I presume - of some internal propagation (mirror/CDN/caching).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is already done by the previous job.
The last step run gem exec rubygems-await pkg/*.gem
, which the logs look like
2025-01-23 13:24:26 +0000 I Awaiting tobee-0.1.2 on https://rubygems.org/
2025-01-23 13:24:26 +0000 I [ pre index] all found!
2025-01-23 13:24:26 +0000 I [full index] missing: tobee-0.1.2
2025-01-23 13:24:26 +0000 I [ gems] missing: tobee-0.1.2
2025-01-23 13:24:26 +0000 I [ gemspecs] missing: tobee-0.1.2
2025-01-23 13:24:26 +0000 I [ info] missing: tobee (tobee-0.1.2)
2025-01-23 13:24:26 +0000 I [ names] missing: tobee
2025-01-23 13:24:26 +0000 I [ versions] missing: tobee (tobee-0.1.2)
2025-01-23 13:24:27 +0000 I [ gemspecs] found tobee-0.1.2
2025-01-23 13:24:27 +0000 I [ gemspecs] all found!
2025-01-23 13:24:27 +0000 I [ gems] found tobee-0.1.2
2025-01-23 13:24:27 +0000 I [ gems] all found!
2025-01-23 13:24:28 +0000 I [ info] missing: tobee (tobee-0.1.2)
2025-01-23 13:24:29 +0000 I [ names] found tobee
2025-01-23 13:24:29 +0000 I [ names] all found!
2025-01-23 13:24:29 +0000 I [ info] found tobee-0.1.2
2025-01-23 13:24:29 +0000 I [ info] all found!
2025-01-23 13:24:30 +0000 I [ versions] missing: tobee (tobee-0.1.2)
2025-01-23 13:24:[39](https://github.com/TonyCTHsu/tobee/actions/runs/12930149327/job/36061017279#step:5:44) +0000 I [full index] missing: tobee-0.1.2
2025-01-23 13:24:40 +0000 I [ versions] found tobee-0.1.2
2025-01-23 13:24:[40](https://github.com/TonyCTHsu/tobee/actions/runs/12930149327/job/36061017279#step:5:45) +0000 I [ versions] all found!
2025-01-23 13:24:51 +0000 I [full index] missing: tobee-0.1.2
2025-01-23 13:25:00 +0000 I [full index] found tobee-0.1.2
2025-01-23 13:25:00 +0000 I [full index] all found!
2025-01-23 13:25:00 +0000 I Found tobee-0.1.2
Datadog ReportBranch report: ✅ 0 Failed, 22101 Passed, 1476 Skipped, 5m 3.46s Total Time |
- id: version | ||
run: | | ||
echo "version=$(ruby -e 'puts Gem::Specification::load(Dir.glob("*.gemspec").first).version')" >> $GITHUB_OUTPUT | ||
- uses: rubygems/release-gem@v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So:
- the
rubygems/release-gem
action creates the tag - which then ends up triggering GitLab CI
- which waits for the gem to be found on rubygems and uses that
Worth a comment outlining this possibly surprising† behaviour here!
† To someone only concerned by GHA and unaware of SSI CI implementation.
BenchmarksBenchmark execution time: 2025-01-24 23:24:08 Comparing candidate commit de8d2c7 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics. |
68a23bc
to
c8d46b6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4315 +/- ##
==========================================
- Coverage 97.72% 97.72% -0.01%
==========================================
Files 1365 1365
Lines 82780 82780
Branches 4206 4206
==========================================
- Hits 80897 80893 -4
- Misses 1883 1887 +4 ☔ View full report in Codecov by Sentry. |
c8d46b6
to
0916911
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just marking as request changes only because I accidentally hit approve 😓
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I read the diff and have no objections, thtough I'll leave it to someone else to apply the checkmark.
What does this PR do?
Publish to rubygems.org via Trusted Publishing
Ref: https://guides.rubygems.org/trusted-publishing/
Change log entry
None.