Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iast): add support for pymysql, mysqldb integrations #12051

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

gnufede
Copy link
Member

@gnufede gnufede commented Jan 23, 2025

Adds IAST sqli sink test for pymysql

APPSEC-56500

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@gnufede gnufede added changelog/no-changelog A changelog entry is not required for this PR. ASM Application Security Monitoring labels Jan 23, 2025
Copy link
Contributor

github-actions bot commented Jan 23, 2025

CODEOWNERS have been resolved as:

.riot/requirements/106990f.txt                                          @DataDog/apm-python
.riot/requirements/1140d28.txt                                          @DataDog/apm-python
.riot/requirements/1568a2f.txt                                          @DataDog/apm-python
.riot/requirements/16a770c.txt                                          @DataDog/apm-python
.riot/requirements/8fd54b8.txt                                          @DataDog/apm-python
tests/appsec/iast/fixtures/taint_sinks/sql_injection_mysqldb.py         @DataDog/asm-python
tests/appsec/iast/fixtures/taint_sinks/sql_injection_pymysql.py         @DataDog/asm-python
.gitlab/services.yml                                                    @DataDog/python-guild @DataDog/apm-core-python
ddtrace/appsec/_iast/_evidence_redaction/sql_sensitive_analyzer.py      @DataDog/asm-python
ddtrace/appsec/_iast/constants.py                                       @DataDog/asm-python
riotfile.py                                                             @DataDog/apm-python
tests/appsec/iast/taint_sinks/test_sql_injection.py                     @DataDog/asm-python
tests/appsec/suitespec.yml                                              @DataDog/asm-python
.riot/requirements/18c560e.txt                                          @DataDog/apm-python

@datadog-dd-trace-py-rkomorn
Copy link

datadog-dd-trace-py-rkomorn bot commented Jan 23, 2025

Datadog Report

Branch report: gnufede/iast-pymysql
Commit report: 0160f22
Test service: dd-trace-py

✅ 0 Failed, 130 Passed, 1468 Skipped, 4m 46.82s Total duration (36m 21.32s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Jan 23, 2025

Benchmarks

Benchmark execution time: 2025-01-24 17:22:43

Comparing candidate commit 0160f22 in PR branch gnufede/iast-pymysql with baseline commit dc7037e in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 394 metrics, 2 unstable metrics.

@gnufede gnufede changed the title chore(iast): add pymysql sink test feat(iast): add support for pymysql, mysqldb integrations Jan 24, 2025
@gnufede gnufede removed the changelog/no-changelog A changelog entry is not required for this PR. label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASM Application Security Monitoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant