-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented New API Security Sampling mechanism #8178
Draft
ValentinZakharov
wants to merge
2
commits into
master
Choose a base branch
from
vzakharov/api_sec_sampling_new
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValentinZakharov
changed the title
Implemented new API Security Sampling
Implemented New API Security Sampling mechanism
Jan 10, 2025
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 61 metrics, 2 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~a9e0fe2225, baseline=1.46.0-SNAPSHOT~03478c8e5c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.069 s) : 0, 1068826
Total [baseline] (8.659 s) : 0, 8658643
Agent [candidate] (1.057 s) : 0, 1056830
Total [candidate] (8.623 s) : 0, 8623115
section iast
Agent [baseline] (1.182 s) : 0, 1182264
Total [baseline] (9.23 s) : 0, 9229707
Agent [candidate] (1.186 s) : 0, 1186283
Total [candidate] (9.26 s) : 0, 9260056
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.184 s) : 0, 1183917
Total [baseline] (9.209 s) : 0, 9209135
Agent [candidate] (1.189 s) : 0, 1189316
Total [candidate] (9.258 s) : 0, 9257522
section iast_TELEMETRY_OFF
Agent [baseline] (1.185 s) : 0, 1185346
Total [baseline] (9.244 s) : 0, 9243771
Agent [candidate] (1.187 s) : 0, 1187066
Total [candidate] (9.229 s) : 0, 9229091
gantt
title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~a9e0fe2225, baseline=1.46.0-SNAPSHOT~03478c8e5c
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (724.386 ms) : 0, 724386
BytebuddyAgent [candidate] (713.437 ms) : 0, 713437
GlobalTracer [baseline] (258.519 ms) : 0, 258519
GlobalTracer [candidate] (255.982 ms) : 0, 255982
AppSec [baseline] (56.261 ms) : 0, 56261
AppSec [candidate] (55.837 ms) : 0, 55837
Remote Config [baseline] (715.702 µs) : 0, 716
Remote Config [candidate] (719.78 µs) : 0, 720
Telemetry [baseline] (13.637 ms) : 0, 13637
Telemetry [candidate] (15.818 ms) : 0, 15818
section iast
BytebuddyAgent [baseline] (831.169 ms) : 0, 831169
BytebuddyAgent [candidate] (832.104 ms) : 0, 832104
GlobalTracer [baseline] (247.067 ms) : 0, 247067
GlobalTracer [candidate] (248.215 ms) : 0, 248215
AppSec [baseline] (58.079 ms) : 0, 58079
AppSec [candidate] (59.591 ms) : 0, 59591
IAST [baseline] (21.388 ms) : 0, 21388
IAST [candidate] (21.727 ms) : 0, 21727
Remote Config [baseline] (672.877 µs) : 0, 673
Remote Config [candidate] (673.511 µs) : 0, 674
Telemetry [baseline] (8.821 ms) : 0, 8821
Telemetry [candidate] (8.926 ms) : 0, 8926
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (832.512 ms) : 0, 832512
BytebuddyAgent [candidate] (835.976 ms) : 0, 835976
GlobalTracer [baseline] (247.343 ms) : 0, 247343
GlobalTracer [candidate] (247.951 ms) : 0, 247951
AppSec [baseline] (58.361 ms) : 0, 58361
AppSec [candidate] (59.185 ms) : 0, 59185
IAST [baseline] (21.224 ms) : 0, 21224
IAST [candidate] (21.521 ms) : 0, 21521
Remote Config [baseline] (659.813 µs) : 0, 660
Remote Config [candidate] (672.043 µs) : 0, 672
Telemetry [baseline] (8.761 ms) : 0, 8761
Telemetry [candidate] (8.855 ms) : 0, 8855
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (833.346 ms) : 0, 833346
BytebuddyAgent [candidate] (834.388 ms) : 0, 834388
GlobalTracer [baseline] (248.081 ms) : 0, 248081
GlobalTracer [candidate] (248.368 ms) : 0, 248368
AppSec [baseline] (58.456 ms) : 0, 58456
AppSec [candidate] (58.541 ms) : 0, 58541
IAST [baseline] (21.005 ms) : 0, 21005
IAST [candidate] (21.134 ms) : 0, 21134
Remote Config [baseline] (655.553 µs) : 0, 656
Remote Config [candidate] (667.579 µs) : 0, 668
Telemetry [baseline] (8.677 ms) : 0, 8677
Telemetry [candidate] (8.783 ms) : 0, 8783
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~a9e0fe2225, baseline=1.46.0-SNAPSHOT~03478c8e5c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.057 s) : 0, 1057059
Total [baseline] (10.479 s) : 0, 10478687
Agent [candidate] (1.059 s) : 0, 1059400
Total [candidate] (10.411 s) : 0, 10411222
section appsec
Agent [baseline] (1.19 s) : 0, 1190414
Total [baseline] (10.746 s) : 0, 10745838
Agent [candidate] (1.196 s) : 0, 1196112
Total [candidate] (10.776 s) : 0, 10776327
section iast
Agent [baseline] (1.191 s) : 0, 1190866
Total [baseline] (10.985 s) : 0, 10984841
Agent [candidate] (1.185 s) : 0, 1184871
Total [candidate] (10.997 s) : 0, 10996603
section profiling
Agent [baseline] (1.283 s) : 0, 1282811
Total [baseline] (10.919 s) : 0, 10918619
Agent [candidate] (1.282 s) : 0, 1282223
Total [candidate] (10.906 s) : 0, 10906017
gantt
title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~a9e0fe2225, baseline=1.46.0-SNAPSHOT~03478c8e5c
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (714.004 ms) : 0, 714004
BytebuddyAgent [candidate] (716.245 ms) : 0, 716245
GlobalTracer [baseline] (256.227 ms) : 0, 256227
GlobalTracer [candidate] (256.961 ms) : 0, 256961
AppSec [baseline] (56.838 ms) : 0, 56838
AppSec [candidate] (56.535 ms) : 0, 56535
Remote Config [baseline] (722.749 µs) : 0, 723
Remote Config [candidate] (723.98 µs) : 0, 724
Telemetry [baseline] (14.262 ms) : 0, 14262
Telemetry [candidate] (13.791 ms) : 0, 13791
section appsec
BytebuddyAgent [baseline] (732.034 ms) : 0, 732034
BytebuddyAgent [candidate] (735.489 ms) : 0, 735489
GlobalTracer [baseline] (253.511 ms) : 0, 253511
GlobalTracer [candidate] (254.489 ms) : 0, 254489
AppSec [baseline] (171.205 ms) : 0, 171205
AppSec [candidate] (172.303 ms) : 0, 172303
Remote Config [baseline] (672.569 µs) : 0, 673
Remote Config [candidate] (658.956 µs) : 0, 659
Telemetry [baseline] (8.25 ms) : 0, 8250
Telemetry [candidate] (8.231 ms) : 0, 8231
IAST [baseline] (19.472 ms) : 0, 19472
IAST [candidate] (19.547 ms) : 0, 19547
section iast
BytebuddyAgent [baseline] (837.474 ms) : 0, 837474
BytebuddyAgent [candidate] (832.362 ms) : 0, 832362
GlobalTracer [baseline] (248.598 ms) : 0, 248598
GlobalTracer [candidate] (247.66 ms) : 0, 247660
AppSec [baseline] (58.368 ms) : 0, 58368
AppSec [candidate] (58.892 ms) : 0, 58892
Remote Config [baseline] (680.201 µs) : 0, 680
Remote Config [candidate] (675.243 µs) : 0, 675
Telemetry [baseline] (8.83 ms) : 0, 8830
Telemetry [candidate] (8.756 ms) : 0, 8756
IAST [baseline] (21.774 ms) : 0, 21774
IAST [candidate] (21.438 ms) : 0, 21438
section profiling
ProfilingAgent [baseline] (95.848 ms) : 0, 95848
ProfilingAgent [candidate] (95.96 ms) : 0, 95960
BytebuddyAgent [baseline] (711.676 ms) : 0, 711676
BytebuddyAgent [candidate] (708.735 ms) : 0, 708735
GlobalTracer [baseline] (369.207 ms) : 0, 369207
GlobalTracer [candidate] (370.916 ms) : 0, 370916
AppSec [baseline] (54.091 ms) : 0, 54091
AppSec [candidate] (54.836 ms) : 0, 54836
Remote Config [baseline] (717.267 µs) : 0, 717
Remote Config [candidate] (710.083 µs) : 0, 710
Telemetry [baseline] (8.836 ms) : 0, 8836
Telemetry [candidate] (8.82 ms) : 0, 8820
Profiling [baseline] (95.872 ms) : 0, 95872
Profiling [candidate] (95.984 ms) : 0, 95984
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 12 metrics, 15 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~a9e0fe2225, baseline=1.46.0-SNAPSHOT~03478c8e5c
dateFormat X
axisFormat %s
section baseline
no_agent (386.25 µs) : 367, 406
. : milestone, 386,
iast (501.818 µs) : 480, 524
. : milestone, 502,
iast_FULL (668.955 µs) : 647, 691
. : milestone, 669,
iast_GLOBAL (527.748 µs) : 506, 550
. : milestone, 528,
iast_HARDCODED_SECRET_DISABLED (502.231 µs) : 481, 524
. : milestone, 502,
iast_INACTIVE (468.569 µs) : 448, 489
. : milestone, 469,
iast_TELEMETRY_OFF (488.947 µs) : 467, 511
. : milestone, 489,
tracing (459.737 µs) : 439, 480
. : milestone, 460,
section candidate
no_agent (381.628 µs) : 362, 402
. : milestone, 382,
iast (505.163 µs) : 483, 527
. : milestone, 505,
iast_FULL (666.945 µs) : 645, 689
. : milestone, 667,
iast_GLOBAL (541.522 µs) : 519, 564
. : milestone, 542,
iast_HARDCODED_SECRET_DISABLED (508.13 µs) : 486, 530
. : milestone, 508,
iast_INACTIVE (461.872 µs) : 440, 483
. : milestone, 462,
iast_TELEMETRY_OFF (488.232 µs) : 467, 510
. : milestone, 488,
tracing (456.689 µs) : 436, 477
. : milestone, 457,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~a9e0fe2225, baseline=1.46.0-SNAPSHOT~03478c8e5c
dateFormat X
axisFormat %s
section baseline
no_agent (1.365 ms) : 1346, 1384
. : milestone, 1365,
appsec (1.764 ms) : 1740, 1787
. : milestone, 1764,
appsec_no_iast (1.775 ms) : 1750, 1799
. : milestone, 1775,
iast (1.5 ms) : 1476, 1523
. : milestone, 1500,
profiling (1.512 ms) : 1489, 1536
. : milestone, 1512,
tracing (1.496 ms) : 1471, 1521
. : milestone, 1496,
section candidate
no_agent (1.384 ms) : 1365, 1404
. : milestone, 1384,
appsec (1.767 ms) : 1743, 1791
. : milestone, 1767,
appsec_no_iast (1.762 ms) : 1738, 1786
. : milestone, 1762,
iast (1.516 ms) : 1493, 1539
. : milestone, 1516,
profiling (1.591 ms) : 1565, 1617
. : milestone, 1591,
tracing (1.509 ms) : 1484, 1534
. : milestone, 1509,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~a9e0fe2225, baseline=1.46.0-SNAPSHOT~03478c8e5c
dateFormat X
axisFormat %s
section baseline
no_agent (1.467 ms) : 1456, 1479
. : milestone, 1467,
appsec (2.358 ms) : 2315, 2400
. : milestone, 2358,
iast (2.101 ms) : 2047, 2155
. : milestone, 2101,
iast_GLOBAL (2.138 ms) : 2084, 2192
. : milestone, 2138,
profiling (1.988 ms) : 1943, 2033
. : milestone, 1988,
tracing (1.936 ms) : 1895, 1978
. : milestone, 1936,
section candidate
no_agent (1.471 ms) : 1460, 1483
. : milestone, 1471,
appsec (2.359 ms) : 2316, 2401
. : milestone, 2359,
iast (2.097 ms) : 2043, 2151
. : milestone, 2097,
iast_GLOBAL (2.144 ms) : 2090, 2198
. : milestone, 2144,
profiling (1.961 ms) : 1918, 2005
. : milestone, 1961,
tracing (1.936 ms) : 1895, 1977
. : milestone, 1936,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~a9e0fe2225, baseline=1.46.0-SNAPSHOT~03478c8e5c
dateFormat X
axisFormat %s
section baseline
no_agent (15.265 s) : 15265000, 15265000
. : milestone, 15265000,
appsec (15.071 s) : 15071000, 15071000
. : milestone, 15071000,
iast (18.647 s) : 18647000, 18647000
. : milestone, 18647000,
iast_GLOBAL (18.001 s) : 18001000, 18001000
. : milestone, 18001000,
profiling (15.157 s) : 15157000, 15157000
. : milestone, 15157000,
tracing (14.756 s) : 14756000, 14756000
. : milestone, 14756000,
section candidate
no_agent (15.054 s) : 15054000, 15054000
. : milestone, 15054000,
appsec (15.046 s) : 15046000, 15046000
. : milestone, 15046000,
iast (19.148 s) : 19148000, 19148000
. : milestone, 19148000,
iast_GLOBAL (17.95 s) : 17950000, 17950000
. : milestone, 17950000,
profiling (15.171 s) : 15171000, 15171000
. : milestone, 15171000,
tracing (14.987 s) : 14987000, 14987000
. : milestone, 14987000,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Implemented new endpoint based API Security Sampling mechanism.
Motivation
This pull request is driven by the need to implement changes based on a newly issued RFC that consolidates all previous specifications. The RFC introduces several minor modifications, including a crucial distinction between user IDs and user logins. By adhering to this updated specification, we aim to enhance our system's accuracy and consistency in tracking user lifecycle events.
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]