-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for session tracking in Vertx #8167
base: master
Are you sure you want to change the base?
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 4 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.45.0-SNAPSHOT~5eb9fbd0c7, baseline=1.45.0-SNAPSHOT~9247ce3d81
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.053 s) : 0, 1052853
Total [baseline] (10.427 s) : 0, 10426945
Agent [candidate] (1.055 s) : 0, 1054522
Total [candidate] (10.385 s) : 0, 10385030
section appsec
Agent [baseline] (1.192 s) : 0, 1192023
Total [baseline] (10.711 s) : 0, 10711476
Agent [candidate] (1.185 s) : 0, 1184867
Total [candidate] (10.735 s) : 0, 10734645
section iast
Agent [baseline] (1.179 s) : 0, 1178584
Total [baseline] (10.934 s) : 0, 10934038
Agent [candidate] (1.179 s) : 0, 1179266
Total [candidate] (10.925 s) : 0, 10925138
section profiling
Agent [baseline] (1.281 s) : 0, 1280775
Total [baseline] (10.824 s) : 0, 10824465
Agent [candidate] (1.274 s) : 0, 1273969
Total [candidate] (10.83 s) : 0, 10830270
gantt
title petclinic - break down per module: candidate=1.45.0-SNAPSHOT~5eb9fbd0c7, baseline=1.45.0-SNAPSHOT~9247ce3d81
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (712.592 ms) : 0, 712592
BytebuddyAgent [candidate] (712.15 ms) : 0, 712150
GlobalTracer [baseline] (255.329 ms) : 0, 255329
GlobalTracer [candidate] (255.514 ms) : 0, 255514
AppSec [baseline] (55.724 ms) : 0, 55724
AppSec [candidate] (55.333 ms) : 0, 55333
Remote Config [baseline] (715.845 µs) : 0, 716
Remote Config [candidate] (720.82 µs) : 0, 721
Telemetry [baseline] (13.474 ms) : 0, 13474
Telemetry [candidate] (15.735 ms) : 0, 15735
section appsec
BytebuddyAgent [baseline] (733.51 ms) : 0, 733510
BytebuddyAgent [candidate] (728.866 ms) : 0, 728866
GlobalTracer [baseline] (254.107 ms) : 0, 254107
GlobalTracer [candidate] (252.083 ms) : 0, 252083
AppSec [baseline] (170.853 ms) : 0, 170853
AppSec [candidate] (170.432 ms) : 0, 170432
Remote Config [baseline] (669.1 µs) : 0, 669
Remote Config [candidate] (654.984 µs) : 0, 655
Telemetry [baseline] (8.219 ms) : 0, 8219
Telemetry [candidate] (8.139 ms) : 0, 8139
IAST [baseline] (19.281 ms) : 0, 19281
IAST [candidate] (19.359 ms) : 0, 19359
section iast
BytebuddyAgent [baseline] (829.018 ms) : 0, 829018
BytebuddyAgent [candidate] (829.459 ms) : 0, 829459
GlobalTracer [baseline] (246.16 ms) : 0, 246160
GlobalTracer [candidate] (246.327 ms) : 0, 246327
AppSec [baseline] (58.217 ms) : 0, 58217
AppSec [candidate] (57.97 ms) : 0, 57970
Remote Config [baseline] (668.192 µs) : 0, 668
Remote Config [candidate] (669.106 µs) : 0, 669
Telemetry [baseline] (8.67 ms) : 0, 8670
Telemetry [candidate] (8.642 ms) : 0, 8642
IAST [baseline] (20.819 ms) : 0, 20819
IAST [candidate] (21.153 ms) : 0, 21153
section profiling
BytebuddyAgent [baseline] (705.319 ms) : 0, 705319
BytebuddyAgent [candidate] (701.697 ms) : 0, 701697
GlobalTracer [baseline] (373.822 ms) : 0, 373822
GlobalTracer [candidate] (372.532 ms) : 0, 372532
AppSec [baseline] (54.29 ms) : 0, 54290
AppSec [candidate] (53.947 ms) : 0, 53947
Remote Config [baseline] (666.566 µs) : 0, 667
Remote Config [candidate] (655.463 µs) : 0, 655
Telemetry [baseline] (8.077 ms) : 0, 8077
Telemetry [candidate] (8.023 ms) : 0, 8023
ProfilingAgent [baseline] (96.493 ms) : 0, 96493
ProfilingAgent [candidate] (95.269 ms) : 0, 95269
Profiling [baseline] (96.517 ms) : 0, 96517
Profiling [candidate] (95.293 ms) : 0, 95293
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.45.0-SNAPSHOT~5eb9fbd0c7, baseline=1.45.0-SNAPSHOT~9247ce3d81
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1054957
Total [baseline] (8.594 s) : 0, 8594247
Agent [candidate] (1.056 s) : 0, 1055616
Total [candidate] (8.635 s) : 0, 8634819
section iast
Agent [baseline] (1.183 s) : 0, 1182594
Total [baseline] (9.2 s) : 0, 9199960
Agent [candidate] (1.196 s) : 0, 1196107
Total [candidate] (9.251 s) : 0, 9250996
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.18 s) : 0, 1180173
Total [baseline] (9.147 s) : 0, 9146956
Agent [candidate] (1.182 s) : 0, 1182368
Total [candidate] (9.147 s) : 0, 9147314
section iast_TELEMETRY_OFF
Agent [baseline] (1.175 s) : 0, 1175347
Total [baseline] (9.203 s) : 0, 9202855
Agent [candidate] (1.194 s) : 0, 1193803
Total [candidate] (9.195 s) : 0, 9194652
gantt
title insecure-bank - break down per module: candidate=1.45.0-SNAPSHOT~5eb9fbd0c7, baseline=1.45.0-SNAPSHOT~9247ce3d81
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (713.705 ms) : 0, 713705
BytebuddyAgent [candidate] (713.708 ms) : 0, 713708
GlobalTracer [baseline] (255.903 ms) : 0, 255903
GlobalTracer [candidate] (257.454 ms) : 0, 257454
AppSec [baseline] (56.022 ms) : 0, 56022
AppSec [candidate] (56.332 ms) : 0, 56332
Remote Config [baseline] (718.897 µs) : 0, 719
Remote Config [candidate] (728.662 µs) : 0, 729
Telemetry [baseline] (13.555 ms) : 0, 13555
Telemetry [candidate] (12.326 ms) : 0, 12326
section iast
BytebuddyAgent [baseline] (831.68 ms) : 0, 831680
BytebuddyAgent [candidate] (842.998 ms) : 0, 842998
GlobalTracer [baseline] (246.98 ms) : 0, 246980
GlobalTracer [candidate] (248.028 ms) : 0, 248028
AppSec [baseline] (58.295 ms) : 0, 58295
AppSec [candidate] (58.496 ms) : 0, 58496
IAST [baseline] (21.148 ms) : 0, 21148
IAST [candidate] (21.578 ms) : 0, 21578
Remote Config [baseline] (667.249 µs) : 0, 667
Remote Config [candidate] (713.194 µs) : 0, 713
Telemetry [baseline] (8.736 ms) : 0, 8736
Telemetry [candidate] (8.994 ms) : 0, 8994
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (830.225 ms) : 0, 830225
BytebuddyAgent [candidate] (831.095 ms) : 0, 831095
GlobalTracer [baseline] (246.271 ms) : 0, 246271
GlobalTracer [candidate] (247.463 ms) : 0, 247463
AppSec [baseline] (58.012 ms) : 0, 58012
AppSec [candidate] (58.208 ms) : 0, 58208
IAST [baseline] (21.173 ms) : 0, 21173
IAST [candidate] (21.069 ms) : 0, 21069
Remote Config [baseline] (664.994 µs) : 0, 665
Remote Config [candidate] (683.446 µs) : 0, 683
Telemetry [baseline] (8.708 ms) : 0, 8708
Telemetry [candidate] (8.702 ms) : 0, 8702
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (826.29 ms) : 0, 826290
BytebuddyAgent [candidate] (839.829 ms) : 0, 839829
GlobalTracer [baseline] (246.605 ms) : 0, 246605
GlobalTracer [candidate] (249.715 ms) : 0, 249715
AppSec [baseline] (57.762 ms) : 0, 57762
AppSec [candidate] (58.295 ms) : 0, 58295
IAST [baseline] (20.428 ms) : 0, 20428
IAST [candidate] (21.23 ms) : 0, 21230
Remote Config [baseline] (631.575 µs) : 0, 632
Remote Config [candidate] (678.269 µs) : 0, 678
Telemetry [baseline] (8.617 ms) : 0, 8617
Telemetry [candidate] (8.79 ms) : 0, 8790
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~5eb9fbd0c7, baseline=1.45.0-SNAPSHOT~9247ce3d81
dateFormat X
axisFormat %s
section baseline
no_agent (1.335 ms) : 1316, 1355
. : milestone, 1335,
appsec (1.746 ms) : 1723, 1769
. : milestone, 1746,
appsec_no_iast (1.746 ms) : 1722, 1770
. : milestone, 1746,
iast (1.483 ms) : 1460, 1506
. : milestone, 1483,
profiling (1.512 ms) : 1489, 1536
. : milestone, 1512,
tracing (1.478 ms) : 1453, 1503
. : milestone, 1478,
section candidate
no_agent (1.365 ms) : 1345, 1384
. : milestone, 1365,
appsec (1.786 ms) : 1762, 1810
. : milestone, 1786,
appsec_no_iast (1.736 ms) : 1712, 1761
. : milestone, 1736,
iast (1.474 ms) : 1451, 1497
. : milestone, 1474,
profiling (1.51 ms) : 1488, 1533
. : milestone, 1510,
tracing (1.481 ms) : 1456, 1506
. : milestone, 1481,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.45.0-SNAPSHOT~5eb9fbd0c7, baseline=1.45.0-SNAPSHOT~9247ce3d81
dateFormat X
axisFormat %s
section baseline
no_agent (374.693 µs) : 355, 394
. : milestone, 375,
iast (495.42 µs) : 474, 517
. : milestone, 495,
iast_FULL (652.814 µs) : 631, 674
. : milestone, 653,
iast_GLOBAL (511.834 µs) : 490, 533
. : milestone, 512,
iast_HARDCODED_SECRET_DISABLED (484.528 µs) : 461, 508
. : milestone, 485,
iast_INACTIVE (446.111 µs) : 425, 467
. : milestone, 446,
iast_TELEMETRY_OFF (475.24 µs) : 454, 497
. : milestone, 475,
tracing (449.764 µs) : 428, 471
. : milestone, 450,
section candidate
no_agent (365.682 µs) : 345, 386
. : milestone, 366,
iast (499.233 µs) : 478, 521
. : milestone, 499,
iast_FULL (647.388 µs) : 626, 669
. : milestone, 647,
iast_GLOBAL (512.455 µs) : 491, 534
. : milestone, 512,
iast_HARDCODED_SECRET_DISABLED (492.621 µs) : 471, 514
. : milestone, 493,
iast_INACTIVE (452.061 µs) : 431, 473
. : milestone, 452,
iast_TELEMETRY_OFF (482.6 µs) : 461, 505
. : milestone, 483,
tracing (450.911 µs) : 430, 472
. : milestone, 451,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~5eb9fbd0c7, baseline=1.45.0-SNAPSHOT~9247ce3d81
dateFormat X
axisFormat %s
section baseline
no_agent (14.933 s) : 14933000, 14933000
. : milestone, 14933000,
appsec (15.143 s) : 15143000, 15143000
. : milestone, 15143000,
iast (18.806 s) : 18806000, 18806000
. : milestone, 18806000,
iast_GLOBAL (17.676 s) : 17676000, 17676000
. : milestone, 17676000,
profiling (15.036 s) : 15036000, 15036000
. : milestone, 15036000,
tracing (14.927 s) : 14927000, 14927000
. : milestone, 14927000,
section candidate
no_agent (15.558 s) : 15558000, 15558000
. : milestone, 15558000,
appsec (14.801 s) : 14801000, 14801000
. : milestone, 14801000,
iast (18.202 s) : 18202000, 18202000
. : milestone, 18202000,
iast_GLOBAL (18.059 s) : 18059000, 18059000
. : milestone, 18059000,
profiling (15.05 s) : 15050000, 15050000
. : milestone, 15050000,
tracing (14.753 s) : 14753000, 14753000
. : milestone, 14753000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~5eb9fbd0c7, baseline=1.45.0-SNAPSHOT~9247ce3d81
dateFormat X
axisFormat %s
section baseline
no_agent (1.481 ms) : 1470, 1493
. : milestone, 1481,
appsec (2.367 ms) : 2325, 2410
. : milestone, 2367,
iast (2.109 ms) : 2055, 2162
. : milestone, 2109,
iast_GLOBAL (2.153 ms) : 2098, 2207
. : milestone, 2153,
profiling (1.979 ms) : 1936, 2022
. : milestone, 1979,
tracing (1.949 ms) : 1907, 1990
. : milestone, 1949,
section candidate
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (2.369 ms) : 2326, 2411
. : milestone, 2369,
iast (2.116 ms) : 2062, 2170
. : milestone, 2116,
iast_GLOBAL (2.145 ms) : 2091, 2199
. : milestone, 2145,
profiling (1.964 ms) : 1921, 2006
. : milestone, 1964,
tracing (1.954 ms) : 1913, 1996
. : milestone, 1954,
|
da10dd8
to
5eb9fbd
Compare
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
What Does This Do
Adds support for session tracking in vert.x 3.x and 4.x
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]