-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add APIs for llm obs #8135
base: master
Are you sure you want to change the base?
add APIs for llm obs #8135
Conversation
84eb184
to
85d0946
Compare
BenchmarksStartupLoadDacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~dd637fd91f, baseline=1.45.0-SNAPSHOT~1951e6f72e
dateFormat X
axisFormat %s
section baseline
no_agent (15.466 s) : 15466000, 15466000
. : milestone, 15466000,
appsec (14.963 s) : 14963000, 14963000
. : milestone, 14963000,
iast (18.888 s) : 18888000, 18888000
. : milestone, 18888000,
iast_GLOBAL (18.069 s) : 18069000, 18069000
. : milestone, 18069000,
profiling (14.796 s) : 14796000, 14796000
. : milestone, 14796000,
tracing (15.008 s) : 15008000, 15008000
. : milestone, 15008000,
section candidate
no_agent (15.469 s) : 15469000, 15469000
. : milestone, 15469000,
appsec (14.8 s) : 14800000, 14800000
. : milestone, 14800000,
iast (18.946 s) : 18946000, 18946000
. : milestone, 18946000,
iast_GLOBAL (17.624 s) : 17624000, 17624000
. : milestone, 17624000,
profiling (15.204 s) : 15204000, 15204000
. : milestone, 15204000,
tracing (15.087 s) : 15087000, 15087000
. : milestone, 15087000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.45.0-SNAPSHOT~dd637fd91f, baseline=1.45.0-SNAPSHOT~1951e6f72e
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1463, 1486
. : milestone, 1474,
appsec (2.359 ms) : 2317, 2401
. : milestone, 2359,
iast (2.106 ms) : 2052, 2159
. : milestone, 2106,
iast_GLOBAL (2.155 ms) : 2101, 2209
. : milestone, 2155,
profiling (1.989 ms) : 1945, 2033
. : milestone, 1989,
tracing (1.94 ms) : 1898, 1981
. : milestone, 1940,
section candidate
no_agent (1.47 ms) : 1459, 1482
. : milestone, 1470,
appsec (2.362 ms) : 2319, 2404
. : milestone, 2362,
iast (2.095 ms) : 2041, 2148
. : milestone, 2095,
iast_GLOBAL (2.152 ms) : 2098, 2206
. : milestone, 2152,
profiling (1.966 ms) : 1923, 2008
. : milestone, 1966,
tracing (1.936 ms) : 1895, 1978
. : milestone, 1936,
|
85d0946
to
dd637fd
Compare
private static LLMObsSpanFactory SPAN_FACTORY = NoOpLLMObsSpanFactory.INSTANCE; | ||
|
||
/** | ||
* This a hook for injecting SpanFactory implementation. It should only be used internally by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, internal APIs should be added to the internal-api
module.
You can keep the same package structure and they will still be visible to the tracer internals.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah gotcha, thanks!
14f71b3
to
5d90450
Compare
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]