Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip spotless on check_* jobs #8101

Merged
merged 3 commits into from
Jan 20, 2025
Merged

Skip spotless on check_* jobs #8101

merged 3 commits into from
Jan 20, 2025
+8 −0

Conversation

smola
Copy link
Member

@smola smola commented Dec 17, 2024

What Does This Do

Skip spotless checks on check_* jobs. We have a dedicated spotless job.

Motivation

On check_profiling job, occasionally:

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':dd-java-agent:agent-profiling:profiling-controller-oracle:spotlessGroovyGradle'.
> java.lang.Exception: You are running Spotless on JVM 8, which limits you to eclipse groovy formatter 4.19.0.
  If you upgrade your JVM to 11+, then you can use eclipse groovy formatter 4.21.0, which may have fixed this problem.

* Try:
> Run with --info or --debug option to get more log output.
> Get more help at https://help.gradle.org.

* Exception is:
org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':dd-java-agent:agent-profiling:profiling-controller-oracle:spotlessGroovyGradle'.
        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.lambda$executeIfValid$1(ExecuteActionsTaskExecuter.java:148)
        at org.gradle.internal.Try$Failure.ifSuccessfulOrElse(Try.java:282)
        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeIfValid(ExecuteActionsTaskExecuter.java:146)
        at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:134)
        at org.gradle.api.internal.tasks.execution.FinalizePropertiesTaskExecuter.execute(FinalizePropertiesTaskExecuter.java:46)
        at org.gradle.api.internal.tasks.execution.ResolveTaskExecutionModeExecuter.execute(ResolveTaskExecutionModeExecuter.java:51)
...

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@smola smola added comp: testing Testing tag: no release notes Changes to exclude from release notes labels Dec 17, 2024
@pr-commenter
Copy link

pr-commenter bot commented Dec 17, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master smola/check-no-spotless
git_commit_date 1737359998 1737366354
git_commit_sha 0767e3c a7da99d
release_version 1.46.0-SNAPSHOT~0767e3c446 1.46.0-SNAPSHOT~a7da99d454
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1737368757 1737368757
ci_job_id 772352572 772352572
ci_pipeline_id 53454226 53454226
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 4 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~a7da99d454, baseline=1.46.0-SNAPSHOT~0767e3c446

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.06 s) : 0, 1060085
Total [baseline] (8.639 s) : 0, 8639109
Agent [candidate] (1.064 s) : 0, 1063759
Total [candidate] (8.612 s) : 0, 8612152
section iast
Agent [baseline] (1.191 s) : 0, 1191034
Total [baseline] (9.206 s) : 0, 9205745
Agent [candidate] (1.184 s) : 0, 1183763
Total [candidate] (9.173 s) : 0, 9173330
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.184 s) : 0, 1183813
Total [baseline] (9.201 s) : 0, 9201062
Agent [candidate] (1.186 s) : 0, 1185621
Total [candidate] (9.166 s) : 0, 9165527
section iast_TELEMETRY_OFF
Agent [baseline] (1.177 s) : 0, 1176917
Total [baseline] (9.176 s) : 0, 9175995
Agent [candidate] (1.179 s) : 0, 1178950
Total [candidate] (9.181 s) : 0, 9180761
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.06 s -
Agent iast 1.191 s 130.949 ms (12.4%)
Agent iast_HARDCODED_SECRET_DISABLED 1.184 s 123.729 ms (11.7%)
Agent iast_TELEMETRY_OFF 1.177 s 116.832 ms (11.0%)
Total tracing 8.639 s -
Total iast 9.206 s 566.636 ms (6.6%)
Total iast_HARDCODED_SECRET_DISABLED 9.201 s 561.954 ms (6.5%)
Total iast_TELEMETRY_OFF 9.176 s 536.886 ms (6.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.064 s -
Agent iast 1.184 s 120.005 ms (11.3%)
Agent iast_HARDCODED_SECRET_DISABLED 1.186 s 121.863 ms (11.5%)
Agent iast_TELEMETRY_OFF 1.179 s 115.191 ms (10.8%)
Total tracing 8.612 s -
Total iast 9.173 s 561.178 ms (6.5%)
Total iast_HARDCODED_SECRET_DISABLED 9.166 s 553.375 ms (6.4%)
Total iast_TELEMETRY_OFF 9.181 s 568.609 ms (6.6%) 
gantt
    title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~a7da99d454, baseline=1.46.0-SNAPSHOT~0767e3c446

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (718.359 ms) : 0, 718359
BytebuddyAgent [candidate] (719.782 ms) : 0, 719782
GlobalTracer [baseline] (255.4 ms) : 0, 255400
GlobalTracer [candidate] (257.066 ms) : 0, 257066
AppSec [baseline] (56.115 ms) : 0, 56115
AppSec [candidate] (57.458 ms) : 0, 57458
Remote Config [baseline] (741.936 µs) : 0, 742
Remote Config [candidate] (752.601 µs) : 0, 753
Telemetry [baseline] (14.409 ms) : 0, 14409
Telemetry [candidate] (13.62 ms) : 0, 13620
section iast
BytebuddyAgent [baseline] (838.361 ms) : 0, 838361
BytebuddyAgent [candidate] (832.35 ms) : 0, 832350
GlobalTracer [baseline] (247.709 ms) : 0, 247709
GlobalTracer [candidate] (246.953 ms) : 0, 246953
AppSec [baseline] (58.45 ms) : 0, 58450
AppSec [candidate] (58.462 ms) : 0, 58462
IAST [baseline] (21.863 ms) : 0, 21863
IAST [candidate] (21.516 ms) : 0, 21516
Remote Config [baseline] (694.504 µs) : 0, 695
Remote Config [candidate] (671.301 µs) : 0, 671
Telemetry [baseline] (8.883 ms) : 0, 8883
Telemetry [candidate] (8.796 ms) : 0, 8796
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (831.762 ms) : 0, 831762
BytebuddyAgent [candidate] (833.483 ms) : 0, 833483
GlobalTracer [baseline] (246.737 ms) : 0, 246737
GlobalTracer [candidate] (247.481 ms) : 0, 247481
AppSec [baseline] (58.635 ms) : 0, 58635
AppSec [candidate] (58.402 ms) : 0, 58402
IAST [baseline] (21.924 ms) : 0, 21924
IAST [candidate] (21.743 ms) : 0, 21743
Remote Config [baseline] (689.929 µs) : 0, 690
Remote Config [candidate] (689.032 µs) : 0, 689
Telemetry [baseline] (9.008 ms) : 0, 9008
Telemetry [candidate] (8.842 ms) : 0, 8842
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (827.932 ms) : 0, 827932
BytebuddyAgent [candidate] (828.853 ms) : 0, 828853
GlobalTracer [baseline] (246.154 ms) : 0, 246154
GlobalTracer [candidate] (246.686 ms) : 0, 246686
AppSec [baseline] (57.914 ms) : 0, 57914
AppSec [candidate] (58.06 ms) : 0, 58060
IAST [baseline] (20.767 ms) : 0, 20767
IAST [candidate] (20.977 ms) : 0, 20977
Remote Config [baseline] (646.425 µs) : 0, 646
Remote Config [candidate] (654.482 µs) : 0, 654
Telemetry [baseline] (8.549 ms) : 0, 8549
Telemetry [candidate] (8.664 ms) : 0, 8664
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~a7da99d454, baseline=1.46.0-SNAPSHOT~0767e3c446

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1055136
Total [baseline] (10.437 s) : 0, 10436696
Agent [candidate] (1.062 s) : 0, 1062144
Total [candidate] (10.467 s) : 0, 10467476
section appsec
Agent [baseline] (1.187 s) : 0, 1187256
Total [baseline] (10.703 s) : 0, 10702601
Agent [candidate] (1.187 s) : 0, 1186576
Total [candidate] (10.697 s) : 0, 10697460
section iast
Agent [baseline] (1.182 s) : 0, 1182105
Total [baseline] (10.956 s) : 0, 10956374
Agent [candidate] (1.187 s) : 0, 1187196
Total [candidate] (10.977 s) : 0, 10977394
section profiling
Agent [baseline] (1.254 s) : 0, 1253583
Total [baseline] (10.816 s) : 0, 10816225
Agent [candidate] (1.254 s) : 0, 1253545
Total [candidate] (10.848 s) : 0, 10847626
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.055 s -
Agent appsec 1.187 s 132.12 ms (12.5%)
Agent iast 1.182 s 126.969 ms (12.0%)
Agent profiling 1.254 s 198.447 ms (18.8%)
Total tracing 10.437 s -
Total appsec 10.703 s 265.905 ms (2.5%)
Total iast 10.956 s 519.677 ms (5.0%)
Total profiling 10.816 s 379.529 ms (3.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.062 s -
Agent appsec 1.187 s 124.432 ms (11.7%)
Agent iast 1.187 s 125.053 ms (11.8%)
Agent profiling 1.254 s 191.401 ms (18.0%)
Total tracing 10.467 s -
Total appsec 10.697 s 229.984 ms (2.2%)
Total iast 10.977 s 509.918 ms (4.9%)
Total profiling 10.848 s 380.15 ms (3.6%) 
gantt
    title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~a7da99d454, baseline=1.46.0-SNAPSHOT~0767e3c446

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (715.052 ms) : 0, 715052
BytebuddyAgent [candidate] (718.332 ms) : 0, 718332
GlobalTracer [baseline] (255.075 ms) : 0, 255075
GlobalTracer [candidate] (257.501 ms) : 0, 257501
AppSec [baseline] (55.57 ms) : 0, 55570
AppSec [candidate] (56.768 ms) : 0, 56768
Remote Config [baseline] (735.693 µs) : 0, 736
Remote Config [candidate] (747.148 µs) : 0, 747
Telemetry [baseline] (13.664 ms) : 0, 13664
Telemetry [candidate] (13.663 ms) : 0, 13663
section appsec
BytebuddyAgent [baseline] (730.531 ms) : 0, 730531
BytebuddyAgent [candidate] (730.277 ms) : 0, 730277
GlobalTracer [baseline] (252.495 ms) : 0, 252495
GlobalTracer [candidate] (252.604 ms) : 0, 252604
AppSec [baseline] (170.909 ms) : 0, 170909
AppSec [candidate] (170.205 ms) : 0, 170205
Remote Config [baseline] (662.786 µs) : 0, 663
Remote Config [candidate] (669.633 µs) : 0, 670
Telemetry [baseline] (8.06 ms) : 0, 8060
Telemetry [candidate] (8.166 ms) : 0, 8166
IAST [baseline] (19.265 ms) : 0, 19265
IAST [candidate] (19.371 ms) : 0, 19371
section iast
BytebuddyAgent [baseline] (831.835 ms) : 0, 831835
BytebuddyAgent [candidate] (834.421 ms) : 0, 834421
GlobalTracer [baseline] (246.371 ms) : 0, 246371
GlobalTracer [candidate] (247.937 ms) : 0, 247937
AppSec [baseline] (58.013 ms) : 0, 58013
AppSec [candidate] (58.36 ms) : 0, 58360
Remote Config [baseline] (665.988 µs) : 0, 666
Remote Config [candidate] (677.084 µs) : 0, 677
Telemetry [baseline] (8.757 ms) : 0, 8757
Telemetry [candidate] (8.875 ms) : 0, 8875
IAST [baseline] (21.492 ms) : 0, 21492
IAST [candidate] (21.869 ms) : 0, 21869
section profiling
ProfilingAgent [baseline] (95.146 ms) : 0, 95146
ProfilingAgent [candidate] (95.015 ms) : 0, 95015
BytebuddyAgent [baseline] (702.987 ms) : 0, 702987
BytebuddyAgent [candidate] (702.731 ms) : 0, 702731
GlobalTracer [baseline] (349.379 ms) : 0, 349379
GlobalTracer [candidate] (350.148 ms) : 0, 350148
AppSec [baseline] (54.832 ms) : 0, 54832
AppSec [candidate] (54.241 ms) : 0, 54241
Remote Config [baseline] (703.84 µs) : 0, 704
Remote Config [candidate] (711.764 µs) : 0, 712
Telemetry [baseline] (8.744 ms) : 0, 8744
Telemetry [candidate] (8.784 ms) : 0, 8784
Profiling [baseline] (95.17 ms) : 0, 95170
Profiling [candidate] (95.04 ms) : 0, 95040
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-01-20T09:55:57 2025-01-20T10:03:05
git_branch master smola/check-no-spotless
git_commit_date 1737359998 1737366354
git_commit_sha 0767e3c a7da99d
release_version 1.46.0-SNAPSHOT~0767e3c446 1.46.0-SNAPSHOT~a7da99d454
start_time 2025-01-20T09:55:43 2025-01-20T10:02:51
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1737367744 1737367744
ci_job_id 772352573 772352573
ci_pipeline_id 53454226 53454226
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~a7da99d454, baseline=1.46.0-SNAPSHOT~0767e3c446
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.37 ms) : 1350, 1389
.   : milestone, 1370,
appsec (1.759 ms) : 1735, 1782
.   : milestone, 1759,
appsec_no_iast (1.785 ms) : 1762, 1808
.   : milestone, 1785,
iast (1.525 ms) : 1500, 1550
.   : milestone, 1525,
profiling (1.517 ms) : 1493, 1541
.   : milestone, 1517,
tracing (1.504 ms) : 1479, 1529
.   : milestone, 1504,
section candidate
no_agent (1.363 ms) : 1344, 1382
.   : milestone, 1363,
appsec (1.747 ms) : 1723, 1771
.   : milestone, 1747,
appsec_no_iast (1.761 ms) : 1737, 1785
.   : milestone, 1761,
iast (1.52 ms) : 1495, 1545
.   : milestone, 1520,
profiling (1.531 ms) : 1507, 1555
.   : milestone, 1531,
tracing (1.518 ms) : 1493, 1543
.   : milestone, 1518,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.37 ms [1.35 ms, 1.389 ms] -
appsec 1.759 ms [1.735 ms, 1.782 ms] 389.075 µs (28.4%)
appsec_no_iast 1.785 ms [1.762 ms, 1.808 ms] 415.638 µs (30.3%)
iast 1.525 ms [1.5 ms, 1.55 ms] 155.282 µs (11.3%)
profiling 1.517 ms [1.493 ms, 1.541 ms] 147.395 µs (10.8%)
tracing 1.504 ms [1.479 ms, 1.529 ms] 134.75 µs (9.8%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.363 ms [1.344 ms, 1.382 ms] -
appsec 1.747 ms [1.723 ms, 1.771 ms] 383.936 µs (28.2%)
appsec_no_iast 1.761 ms [1.737 ms, 1.785 ms] 397.858 µs (29.2%)
iast 1.52 ms [1.495 ms, 1.545 ms] 156.834 µs (11.5%)
profiling 1.531 ms [1.507 ms, 1.555 ms] 167.386 µs (12.3%)
tracing 1.518 ms [1.493 ms, 1.543 ms] 154.712 µs (11.3%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~a7da99d454, baseline=1.46.0-SNAPSHOT~0767e3c446
    dateFormat X
    axisFormat %s
section baseline
no_agent (382.199 µs) : 362, 403
.   : milestone, 382,
iast (505.411 µs) : 484, 527
.   : milestone, 505,
iast_FULL (741.879 µs) : 720, 764
.   : milestone, 742,
iast_GLOBAL (563.062 µs) : 540, 586
.   : milestone, 563,
iast_HARDCODED_SECRET_DISABLED (509.565 µs) : 488, 531
.   : milestone, 510,
iast_INACTIVE (464.119 µs) : 442, 486
.   : milestone, 464,
iast_TELEMETRY_OFF (519.602 µs) : 498, 542
.   : milestone, 520,
tracing (454.254 µs) : 434, 475
.   : milestone, 454,
section candidate
no_agent (380.387 µs) : 361, 400
.   : milestone, 380,
iast (510.078 µs) : 488, 532
.   : milestone, 510,
iast_FULL (744.067 µs) : 722, 766
.   : milestone, 744,
iast_GLOBAL (571.806 µs) : 549, 594
.   : milestone, 572,
iast_HARDCODED_SECRET_DISABLED (509.296 µs) : 488, 531
.   : milestone, 509,
iast_INACTIVE (458.646 µs) : 437, 480
.   : milestone, 459,
iast_TELEMETRY_OFF (497.882 µs) : 476, 520
.   : milestone, 498,
tracing (453.568 µs) : 432, 475
.   : milestone, 454,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 382.199 µs [361.618 µs, 402.781 µs] -
iast 505.411 µs [484.112 µs, 526.71 µs] 123.212 µs (32.2%)
iast_FULL 741.879 µs [720.002 µs, 763.757 µs] 359.68 µs (94.1%)
iast_GLOBAL 563.062 µs [539.693 µs, 586.43 µs] 180.862 µs (47.3%)
iast_HARDCODED_SECRET_DISABLED 509.565 µs [487.959 µs, 531.171 µs] 127.365 µs (33.3%)
iast_INACTIVE 464.119 µs [442.238 µs, 485.999 µs] 81.92 µs (21.4%)
iast_TELEMETRY_OFF 519.602 µs [497.606 µs, 541.598 µs] 137.403 µs (36.0%)
tracing 454.254 µs [433.507 µs, 475.001 µs] 72.054 µs (18.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 380.387 µs [360.721 µs, 400.053 µs] -
iast 510.078 µs [488.49 µs, 531.666 µs] 129.691 µs (34.1%)
iast_FULL 744.067 µs [722.027 µs, 766.107 µs] 363.679 µs (95.6%)
iast_GLOBAL 571.806 µs [549.143 µs, 594.469 µs] 191.419 µs (50.3%)
iast_HARDCODED_SECRET_DISABLED 509.296 µs [487.564 µs, 531.028 µs] 128.909 µs (33.9%)
iast_INACTIVE 458.646 µs [437.338 µs, 479.954 µs] 78.259 µs (20.6%)
iast_TELEMETRY_OFF 497.882 µs [475.702 µs, 520.062 µs] 117.495 µs (30.9%)
tracing 453.568 µs [432.239 µs, 474.896 µs] 73.18 µs (19.2%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master smola/check-no-spotless
git_commit_date 1737359998 1737366354
git_commit_sha 0767e3c a7da99d
release_version 1.46.0-SNAPSHOT~0767e3c446 1.46.0-SNAPSHOT~a7da99d454
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1737368299 1737368299
ci_job_id 772352574 772352574
ci_pipeline_id 53454226 53454226
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~a7da99d454, baseline=1.46.0-SNAPSHOT~0767e3c446
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.478 ms) : 1467, 1490
.   : milestone, 1478,
appsec (2.365 ms) : 2322, 2408
.   : milestone, 2365,
iast (2.118 ms) : 2063, 2172
.   : milestone, 2118,
iast_GLOBAL (2.15 ms) : 2096, 2205
.   : milestone, 2150,
profiling (1.966 ms) : 1923, 2009
.   : milestone, 1966,
tracing (1.956 ms) : 1914, 1998
.   : milestone, 1956,
section candidate
no_agent (1.473 ms) : 1462, 1485
.   : milestone, 1473,
appsec (2.357 ms) : 2314, 2400
.   : milestone, 2357,
iast (2.104 ms) : 2050, 2158
.   : milestone, 2104,
iast_GLOBAL (2.143 ms) : 2088, 2197
.   : milestone, 2143,
profiling (1.991 ms) : 1946, 2035
.   : milestone, 1991,
tracing (1.946 ms) : 1905, 1988
.   : milestone, 1946,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.478 ms [1.467 ms, 1.49 ms] -
appsec 2.365 ms [2.322 ms, 2.408 ms] 886.525 µs (60.0%)
iast 2.118 ms [2.063 ms, 2.172 ms] 639.345 µs (43.2%)
iast_GLOBAL 2.15 ms [2.096 ms, 2.205 ms] 671.679 µs (45.4%)
profiling 1.966 ms [1.923 ms, 2.009 ms] 487.297 µs (33.0%)
tracing 1.956 ms [1.914 ms, 1.998 ms] 477.616 µs (32.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.473 ms [1.462 ms, 1.485 ms] -
appsec 2.357 ms [2.314 ms, 2.4 ms] 883.704 µs (60.0%)
iast 2.104 ms [2.05 ms, 2.158 ms] 630.75 µs (42.8%)
iast_GLOBAL 2.143 ms [2.088 ms, 2.197 ms] 669.403 µs (45.4%)
profiling 1.991 ms [1.946 ms, 2.035 ms] 517.404 µs (35.1%)
tracing 1.946 ms [1.905 ms, 1.988 ms] 473.214 µs (32.1%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~a7da99d454, baseline=1.46.0-SNAPSHOT~0767e3c446
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.893 s) : 14893000, 14893000
.   : milestone, 14893000,
appsec (14.895 s) : 14895000, 14895000
.   : milestone, 14895000,
iast (19.051 s) : 19051000, 19051000
.   : milestone, 19051000,
iast_GLOBAL (17.878 s) : 17878000, 17878000
.   : milestone, 17878000,
profiling (15.148 s) : 15148000, 15148000
.   : milestone, 15148000,
tracing (15.016 s) : 15016000, 15016000
.   : milestone, 15016000,
section candidate
no_agent (15.301 s) : 15301000, 15301000
.   : milestone, 15301000,
appsec (15.133 s) : 15133000, 15133000
.   : milestone, 15133000,
iast (18.843 s) : 18843000, 18843000
.   : milestone, 18843000,
iast_GLOBAL (18.031 s) : 18031000, 18031000
.   : milestone, 18031000,
profiling (14.855 s) : 14855000, 14855000
.   : milestone, 14855000,
tracing (15.027 s) : 15027000, 15027000
.   : milestone, 15027000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.893 s [14.893 s, 14.893 s] -
appsec 14.895 s [14.895 s, 14.895 s] 2.0 ms (0.0%)
iast 19.051 s [19.051 s, 19.051 s] 4.158 s (27.9%)
iast_GLOBAL 17.878 s [17.878 s, 17.878 s] 2.985 s (20.0%)
profiling 15.148 s [15.148 s, 15.148 s] 255.0 ms (1.7%)
tracing 15.016 s [15.016 s, 15.016 s] 123.0 ms (0.8%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.301 s [15.301 s, 15.301 s] -
appsec 15.133 s [15.133 s, 15.133 s] -168.0 ms (-1.1%)
iast 18.843 s [18.843 s, 18.843 s] 3.542 s (23.1%)
iast_GLOBAL 18.031 s [18.031 s, 18.031 s] 2.73 s (17.8%)
profiling 14.855 s [14.855 s, 14.855 s] -446.0 ms (-2.9%)
tracing 15.027 s [15.027 s, 15.027 s] -274.0 ms (-1.8%)

@smola smola marked this pull request as ready for review December 17, 2024 16:29
@smola smola requested a review from a team as a code owner December 17, 2024 16:29
@github-actions GitHub Actions
Copy link
Contributor

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Remove the tag from the pull request title

If you need help, please check our contributing guidelines.

@smola smola changed the title [ci] Skip spotless on check_* jobs Skip spotless on check_* jobs Dec 17, 2024
@smola smola marked this pull request as draft December 17, 2024 16:50
PerfectSlayer
PerfectSlayer approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@smola smola marked this pull request as ready for review January 16, 2025 07:57
@smola smola added tag: no release notes Changes to exclude from release notes and removed tag: no release notes Changes to exclude from release notes labels Jan 20, 2025
@smola smola merged commit a37d082 into master Jan 20, 2025
173 of 174 checks passed
@smola smola deleted the smola/check-no-spotless branch January 20, 2025 13:48
@github-actions github-actions bot added this to the 1.46.0 milestone Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuel-alvarez-alvarez manuel-alvarez-alvarez manuel-alvarez-alvarez approved these changes

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

Assignees
No one assigned
Labels
comp: testing Testing tag: no release notes Changes to exclude from release notes
Projects
None yet
Milestone
1.46.0
Development

Successfully merging this pull request may close these issues.
3 participants
@smola @PerfectSlayer @manuel-alvarez-alvarez