Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support valkey-go tracing #3081

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Support valkey-go tracing #3081

wants to merge 1 commit into from

Conversation

keisku
Copy link

@keisku keisku commented Jan 12, 2025

What does this PR do?

2025-01-12_20-01-09

Motivation

#2920

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
  • For internal contributors, a matching PR should be created to the v2-dev branch and reviewed by @DataDog/apm-go.

Unsure? Have a question? Request a review!

@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label Jan 12, 2025
@datadog-datadog-prod-us1
Copy link

Datadog Report

Branch report: keisku/valkey-go-support
Commit report: 56b2d8f
Test service: dd-trace-go

✅ 0 Failed, 5120 Passed, 70 Skipped, 2m 54.71s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Jan 12, 2025

Benchmarks

Benchmark execution time: 2025-01-12 11:39:23

Comparing candidate commit d543f6f in PR branch keisku/valkey-go-support with baseline commit 27624f6 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 1 unstable metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant