internal: add supported versions for v2 #3070
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 4076 Passed, 64 Skipped, 2m 49.19s Total Time |
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
| # note: This will only run when there *are* changes to integration versions | ||
| - name: Create Pull Request | ||
| id: pr | ||
| uses: peter-evans/create-pull-request@v6 |
There was a problem hiding this comment.
🟠 Code Vulnerability
Workflow depends on a GitHub actions pinned by tag (...read more)
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| if: ${{ github.event.workflow_run.conclusion == 'success' }} | ||
| steps: | ||
| - uses: actions/checkout@v4 |
There was a problem hiding this comment.
🟠 Code Vulnerability
Workflow depends on a GitHub actions pinned by tag (...read more)
| @@ -0,0 +1,44 @@ | |||
| name: Supported Versions | |||
| on: | |||
| workflow_run: | |||
There was a problem hiding this comment.
🟠 Code Vulnerability
Dangerous GitHub actions trigger (...read more)
BenchmarksBenchmark execution time: 2025-01-10 19:09:39 Comparing candidate commit 1daec69 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 1 unstable metrics. |
quinna-h
changed the title
| var mu sync.Mutex | ||
|
|
||
| updatedModules := make([]ModuleVersion, 0, len(modules)) |
There was a problem hiding this comment.
| var mu sync.Mutex | |
| updatedModules := make([]ModuleVersion, 0, len(modules)) | |
| updatedModules := make([]ModuleVersion, len(modules)) |
nit: you can avoid the mutex by assigning the slice by index instead of using append
updatedModules[i] = ...| @@ -844,3 +846,7 @@ func isAWSMessagingSendOp(awsService, awsOperation string) bool { | |||
| } | |||
| return false | |||
| } | |||
|
|
|||
| func GetPackages() map[Package]PackageInfo { | |||
| return packages | |||
There was a problem hiding this comment.
hmm the point of making this variable unexported was so it cannot be modified from outside of this package. If we want to keep it being this way, this function should return a deep copy of this map.
cc @darccio any thoughts?
| // Path to contrib/{packageName} | ||
| contribPath := filepath.Join("contrib", packageName) | ||
| goModPath := filepath.Join(contribPath, "go.mod") | ||
|
|
||
| // Check if go.mod exists in directory | ||
| if _, err := os.Stat(goModPath); os.IsNotExist(err) { | ||
| return ModuleVersion{}, fmt.Errorf("go.mod not found in %s", contribPath) | ||
| } |
There was a problem hiding this comment.
this means you are no longer using the integration_go.mod file right? in that case then we can just remove it.
There was a problem hiding this comment.
yes, putting this in a separate PR: #3078, which will modify the 'check for new major version packages' workflow (which was what we needed integration_go.mod for in the first place)
What does this PR do?
contrib/<package_name>/go.mod, and the maximum fromgo list -m -versions <repository>supported_versions.mdwhich states the package, minimum and maximum versions tested/supported, and whether it is auto-instrumented using this definition: https://github.com/DataDog/orchestrion#supported-librariesMotivation
Reviewer's Checklist
v2-devbranch and reviewed by @DataDog/apm-go.Unsure? Have a question? Request a review!