Change the way we collect ip and header #6591

anna-git · 2025-01-24T13:07:42Z

Summary of changes

dont return anything if a custom ip header has been specified and isn't returning anything
log.debug instead of warning if this happens, it's going to happen all the time
remove the deprecated x-forwarded header
cf https://datadoghq.atlassian.net/wiki/spaces/SAAL/pages/2118779066/Client+IP+addresses+resolution
add nullable enable in the extractor classes
improve unit tests by naming the scenario, and add the relevant ones.

Reason for change

Customer asked and specification regarding custom ip headers and new removed header has to be updated

Implementation details

Test coverage

added 2 and improved existing unit tests

Other details

- if custom header doesnt return anything, dont fallback on other ips - enable nullable - remove x-forwarded which is deprecated

andrewlock · 2025-01-24T14:01:26Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6591) - mean (69ms)  : 66, 71
     .   : milestone, 69,
    master - mean (69ms)  : 66, 72
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6591) - mean (983ms)  : 957, 1010
     .   : milestone, 983,
    master - mean (979ms)  : 953, 1004
     .   : milestone, 979,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6591) - mean (108ms)  : 106, 109
     .   : milestone, 108,
    master - mean (108ms)  : 105, 110
     .   : milestone, 108,

    section CallTarget+Inlining+NGEN
    This PR (6591) - mean (683ms)  : 665, 701
     .   : milestone, 683,
    master - mean (683ms)  : 666, 700
     .   : milestone, 683,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6591) - mean (91ms)  : 89, 93
     .   : milestone, 91,
    master - mean (91ms)  : 89, 93
     .   : milestone, 91,

    section CallTarget+Inlining+NGEN
    This PR (6591) - mean (637ms)  : 623, 651
     .   : milestone, 637,
    master - mean (639ms)  : 611, 667
     .   : milestone, 639,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6591) - mean (190ms)  : 185, 195
     .   : milestone, 190,
    master - mean (189ms)  : 186, 193
     .   : milestone, 189,

    section CallTarget+Inlining+NGEN
    This PR (6591) - mean (1,099ms)  : 1055, 1142
     .   : milestone, 1099,
    master - mean (1,086ms)  : 1059, 1112
     .   : milestone, 1086,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6591) - mean (277ms)  : 271, 283
     .   : milestone, 277,
    master - mean (276ms)  : 273, 280
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (6591) - mean (876ms)  : 850, 901
     .   : milestone, 876,
    master - mean (876ms)  : 847, 905
     .   : milestone, 876,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6591) - mean (265ms)  : 261, 270
     .   : milestone, 265,
    master - mean (265ms)  : 261, 270
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (6591) - mean (856ms)  : 824, 888
     .   : milestone, 856,
    master - mean (850ms)  : 815, 885
     .   : milestone, 850,

datadog-ddstaging · 2025-01-24T14:04:22Z

Datadog Report

Branch report: anna/amend-ip-collection-secscan
Commit report: df87607
Test service: dd-trace-dotnet

✅ 0 Failed, 243189 Passed, 2089 Skipped, 19h 33m 28.32s Total Time
⌛ 1 Performance Regression

⌛ Performance Regressions vs Default Branch (1)

WriteAndFlushEnrichedTraces - Benchmarks.Trace.AgentWriterBenchmark 715.91µs (+60.52µs, +9%) - Details

andrewlock · 2025-01-24T14:22:29Z

Benchmarks Report for tracer 🐌

Benchmarks for #6591 compared to master:

1 benchmarks are faster, with geometric mean 1.172
1 benchmarks are slower, with geometric mean 1.130
1 benchmarks have fewer allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	7.96μs	43.7ns	266ns	0.016	0.00802	0	5.61 KB
master	`StartStopWithChild`	netcoreapp3.1	10.1μs	54.5ns	293ns	0.0246	0.00982	0	5.8 KB
master	`StartStopWithChild`	net472	16.3μs	59.1ns	229ns	1.05	0.319	0.101	6.22 KB
#6591	`StartStopWithChild`	net6.0	8.2μs	45ns	281ns	0.0157	0.00784	0	5.61 KB
#6591	`StartStopWithChild`	netcoreapp3.1	10.1μs	47.2ns	222ns	0.0216	0.0108	0	5.81 KB
#6591	`StartStopWithChild`	net472	16μs	64.4ns	250ns	1.04	0.311	0.104	6.21 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	480μs	232ns	898ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	648μs	300ns	1.12μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	845μs	405ns	1.57μs	0.422	3.3 KB
#6591	`WriteAndFlushEnrichedTraces`	net6.0	481μs	335ns	1.25μs	0	2.7 KB
#6591	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	716μs	184ns	663ns	0	2.7 KB
#6591	`WriteAndFlushEnrichedTraces`	net472	878μs	562ns	2.03μs	0.431	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	129μs	353ns	1.37μs	0.191	14.47 KB
master	`SendRequest`	netcoreapp3.1	145μs	428ns	1.66μs	0.215	17.27 KB
master	`SendRequest`	net472	0.00656ns	0.0022ns	0.00852ns	0	0 b
#6591	`SendRequest`	net6.0	128μs	264ns	988ns	0.194	14.47 KB
#6591	`SendRequest`	netcoreapp3.1	145μs	455ns	1.76μs	0.214	17.27 KB
#6591	`SendRequest`	net472	0.00185ns	0.00107ns	0.00414ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #6591

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑net6.0	41.87 KB	41.52 KB	-346 B	-0.83%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	562μs	2.56μs	9.58μs	0.53	0	0	41.87 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	656μs	3.03μs	11.7μs	0.329	0	0	41.71 KB
master	`WriteAndFlushEnrichedTraces`	net472	838μs	2.81μs	10.9μs	8.69	2.48	0.414	53.36 KB
#6591	`WriteAndFlushEnrichedTraces`	net6.0	573μs	3.11μs	17.9μs	0.566	0	0	41.52 KB
#6591	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	637μs	2.36μs	9.14μs	0.324	0	0	41.63 KB
#6591	`WriteAndFlushEnrichedTraces`	net472	837μs	2.66μs	9.96μs	8.08	2.55	0.425	53.29 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	net6.0	1.3μs	1.23ns	4.77ns	0.0143	0	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.74μs	1.02ns	3.83ns	0.0132	0	1.02 KB
master	`ExecuteNonQuery`	net472	2.11μs	1.34ns	5.02ns	0.156	0.00106	987 B
#6591	`ExecuteNonQuery`	net6.0	1.22μs	0.722ns	2.7ns	0.014	0	1.02 KB
#6591	`ExecuteNonQuery`	netcoreapp3.1	1.85μs	1.84ns	7.14ns	0.0137	0	1.02 KB
#6591	`ExecuteNonQuery`	net472	2.12μs	1.49ns	5.16ns	0.157	0.00106	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.15μs	0.463ns	1.73ns	0.0138	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.59μs	1.12ns	4.32ns	0.0136	976 B
master	`CallElasticsearch`	net472	2.58μs	2.46ns	9.53ns	0.157	995 B
master	`CallElasticsearchAsync`	net6.0	1.31μs	6.39ns	25.6ns	0.0136	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.72μs	1.06ns	3.98ns	0.0137	1.02 KB
master	`CallElasticsearchAsync`	net472	2.73μs	1.06ns	4.09ns	0.166	1.05 KB
#6591	`CallElasticsearch`	net6.0	1.2μs	0.685ns	2.56ns	0.0138	976 B
#6591	`CallElasticsearch`	netcoreapp3.1	1.54μs	0.533ns	1.92ns	0.0133	976 B
#6591	`CallElasticsearch`	net472	2.61μs	1.76ns	6.57ns	0.157	995 B
#6591	`CallElasticsearchAsync`	net6.0	1.28μs	0.455ns	1.76ns	0.0135	952 B
#6591	`CallElasticsearchAsync`	netcoreapp3.1	1.6μs	0.662ns	2.48ns	0.0135	1.02 KB
#6591	`CallElasticsearchAsync`	net472	2.65μs	1.47ns	5.5ns	0.166	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.32μs	0.46ns	1.72ns	0.0132	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.65μs	1.28ns	4.77ns	0.0126	952 B
master	`ExecuteAsync`	net472	1.78μs	0.56ns	2.02ns	0.145	915 B
#6591	`ExecuteAsync`	net6.0	1.23μs	0.63ns	2.44ns	0.0135	952 B
#6591	`ExecuteAsync`	netcoreapp3.1	1.74μs	0.75ns	2.81ns	0.013	952 B
#6591	`ExecuteAsync`	net472	1.78μs	0.432ns	1.67ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.4μs	1.14ns	4.26ns	0.0307	2.31 KB
master	`SendAsync`	netcoreapp3.1	5.52μs	1.63ns	6.08ns	0.0385	2.85 KB
master	`SendAsync`	net472	7.35μs	1.51ns	5.86ns	0.492	3.12 KB
#6591	`SendAsync`	net6.0	4.38μs	1.33ns	4.99ns	0.0308	2.31 KB
#6591	`SendAsync`	netcoreapp3.1	5.21μs	3.08ns	11.9ns	0.0365	2.85 KB
#6591	`SendAsync`	net472	7.43μs	1.05ns	4.08ns	0.494	3.12 KB

Benchmarks.Trace.ILoggerBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6591

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑netcoreapp3.1	1.130	2,100.97	2,374.07

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.46μs	0.734ns	2.75ns	0.0232	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.1μs	2.21ns	8.55ns	0.0216	1.64 KB
master	`EnrichedLog`	net472	2.74μs	1.67ns	6.46ns	0.249	1.57 KB
#6591	`EnrichedLog`	net6.0	1.5μs	0.844ns	2.92ns	0.0226	1.64 KB
#6591	`EnrichedLog`	netcoreapp3.1	2.37μs	0.797ns	2.98ns	0.0214	1.64 KB
#6591	`EnrichedLog`	net472	2.65μs	1.3ns	5.02ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	116μs	195ns	755ns	0	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	120μs	94.8ns	367ns	0	0	4.28 KB
master	`EnrichedLog`	net472	151μs	127ns	493ns	0.678	0.226	4.46 KB
#6591	`EnrichedLog`	net6.0	116μs	68.2ns	264ns	0.0577	0	4.28 KB
#6591	`EnrichedLog`	netcoreapp3.1	120μs	147ns	550ns	0	0	4.28 KB
#6591	`EnrichedLog`	net472	152μs	91.3ns	353ns	0.682	0.227	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.02μs	1.13ns	4.39ns	0.0317	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.28μs	1.6ns	6.21ns	0.0279	2.2 KB
master	`EnrichedLog`	net472	4.91μs	1.01ns	3.9ns	0.319	2.02 KB
#6591	`EnrichedLog`	net6.0	3.01μs	1.03ns	3.84ns	0.0302	2.2 KB
#6591	`EnrichedLog`	netcoreapp3.1	4.23μs	1.28ns	4.79ns	0.0296	2.2 KB
#6591	`EnrichedLog`	net472	5.01μs	1.17ns	4.52ns	0.319	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.44μs	1.29ns	4.99ns	0.0158	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.82μs	1.57ns	6.08ns	0.0154	1.14 KB
master	`SendReceive`	net472	2.1μs	0.89ns	3.45ns	0.183	1.16 KB
#6591	`SendReceive`	net6.0	1.34μs	0.553ns	2.07ns	0.0162	1.14 KB
#6591	`SendReceive`	netcoreapp3.1	1.82μs	0.938ns	3.63ns	0.0147	1.14 KB
#6591	`SendReceive`	net472	2.06μs	0.669ns	2.41ns	0.183	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.75μs	0.622ns	2.41ns	0.0221	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.94μs	1.15ns	4.31ns	0.0217	1.65 KB
master	`EnrichedLog`	net472	4.42μs	1.99ns	7.7ns	0.323	2.04 KB
#6591	`EnrichedLog`	net6.0	2.7μs	1.16ns	4.5ns	0.023	1.6 KB
#6591	`EnrichedLog`	netcoreapp3.1	3.97μs	6.37ns	24.7ns	0.0219	1.65 KB
#6591	`EnrichedLog`	net472	4.42μs	2.72ns	10.5ns	0.323	2.04 KB

Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6591

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1	1.172	765.16	652.85

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	399ns	0.735ns	2.85ns	0.00812	576 B
master	`StartFinishSpan`	netcoreapp3.1	565ns	1.19ns	4.61ns	0.00771	576 B
master	`StartFinishSpan`	net472	615ns	0.948ns	3.67ns	0.0915	578 B
master	`StartFinishScope`	net6.0	544ns	0.645ns	2.5ns	0.0098	696 B
master	`StartFinishScope`	netcoreapp3.1	765ns	0.914ns	3.54ns	0.00916	696 B
master	`StartFinishScope`	net472	860ns	2.32ns	9ns	0.104	658 B
#6591	`StartFinishSpan`	net6.0	400ns	0.756ns	2.93ns	0.00796	576 B
#6591	`StartFinishSpan`	netcoreapp3.1	563ns	1.03ns	3.97ns	0.00779	576 B
#6591	`StartFinishSpan`	net472	595ns	0.871ns	3.37ns	0.0918	578 B
#6591	`StartFinishScope`	net6.0	563ns	0.932ns	3.61ns	0.00959	696 B
#6591	`StartFinishScope`	netcoreapp3.1	665ns	3.71ns	25.2ns	0.00931	696 B
#6591	`StartFinishScope`	net472	856ns	1.78ns	6.89ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	634ns	1.42ns	5.5ns	0.00986	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	895ns	1.04ns	4.01ns	0.00952	696 B
master	`RunOnMethodBegin`	net472	1.09μs	1.38ns	5.17ns	0.104	658 B
#6591	`RunOnMethodBegin`	net6.0	651ns	1.4ns	5.41ns	0.00969	696 B
#6591	`RunOnMethodBegin`	netcoreapp3.1	961ns	1.56ns	5.62ns	0.00908	696 B
#6591	`RunOnMethodBegin`	net472	1.03μs	2.07ns	8.01ns	0.104	658 B

andrewlock · 2025-01-24T14:27:26Z

Benchmarks Report for appsec 🐌

Benchmarks for #6591 compared to master:

1 benchmarks are faster, with geometric mean 1.212
1 benchmarks are slower, with geometric mean 1.142
1 benchmarks have fewer allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.Asm.AppSecBodyBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6591

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody‑netcoreapp3.1	1.142	192.87	220.19

Faster 🎉 in #6591

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorMoreComplexBody‑net472	1.212	4,363.78	3,600.68

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`AllCycleSimpleBody`	net6.0	204μs	78.4ns	304ns	2.66	0	188.69 KB
master	`AllCycleSimpleBody`	netcoreapp3.1	294μs	84.1ns	303ns	2.65	0	196.02 KB
master	`AllCycleSimpleBody`	net472	266μs	107ns	415ns	35.8	1.99	225.75 KB
master	`AllCycleMoreComplexBody`	net6.0	207μs	71.2ns	257ns	2.7	0	192.19 KB
master	`AllCycleMoreComplexBody`	netcoreapp3.1	311μs	307ns	1.15μs	2.62	0	199.43 KB
master	`AllCycleMoreComplexBody`	net472	276μs	429ns	1.66μs	36.4	2.05	229.27 KB
master	`ObjectExtractorSimpleBody`	net6.0	135ns	0.166ns	0.598ns	0.00392	0	280 B
master	`ObjectExtractorSimpleBody`	netcoreapp3.1	193ns	0.153ns	0.571ns	0.00369	0	272 B
master	`ObjectExtractorSimpleBody`	net472	170ns	0.174ns	0.674ns	0.0446	0	281 B
master	`ObjectExtractorMoreComplexBody`	net6.0	2.88μs	2.19ns	8.47ns	0.0533	0	3.78 KB
master	`ObjectExtractorMoreComplexBody`	netcoreapp3.1	3.85μs	1.66ns	6.43ns	0.0499	0	3.69 KB
master	`ObjectExtractorMoreComplexBody`	net472	4.36μs	1.07ns	3.71ns	0.601	0.00656	3.8 KB
#6591	`AllCycleSimpleBody`	net6.0	206μs	139ns	540ns	2.69	0	188.69 KB
#6591	`AllCycleSimpleBody`	netcoreapp3.1	308μs	150ns	559ns	2.62	0	196.02 KB
#6591	`AllCycleSimpleBody`	net472	270μs	232ns	899ns	35.8	2.02	225.75 KB
#6591	`AllCycleMoreComplexBody`	net6.0	208μs	110ns	427ns	2.72	0	192.19 KB
#6591	`AllCycleMoreComplexBody`	netcoreapp3.1	313μs	76.7ns	277ns	2.66	0	199.43 KB
#6591	`AllCycleMoreComplexBody`	net472	275μs	168ns	649ns	36.3	2.06	229.27 KB
#6591	`ObjectExtractorSimpleBody`	net6.0	139ns	0.181ns	0.702ns	0.00396	0	280 B
#6591	`ObjectExtractorSimpleBody`	netcoreapp3.1	220ns	0.103ns	0.4ns	0.00375	0	272 B
#6591	`ObjectExtractorSimpleBody`	net472	181ns	0.234ns	0.904ns	0.0446	0	281 B
#6591	`ObjectExtractorMoreComplexBody`	net6.0	3.02μs	1.62ns	6.27ns	0.0537	0	3.78 KB
#6591	`ObjectExtractorMoreComplexBody`	netcoreapp3.1	3.9μs	14.2ns	54.8ns	0.05	0	3.69 KB
#6591	`ObjectExtractorMoreComplexBody`	net472	3.6μs	2.81ns	9.72ns	0.602	0.00541	3.8 KB

Benchmarks.Trace.Asm.AppSecEncoderBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EncodeArgs`	net6.0	36.9μs	24.3ns	90.8ns	0.46	0	32.4 KB
master	`EncodeArgs`	netcoreapp3.1	54μs	14.3ns	55.5ns	0.429	0	32.4 KB
master	`EncodeArgs`	net472	67.8μs	40.8ns	153ns	5.13	0.068	32.5 KB
master	`EncodeLegacyArgs`	net6.0	73.7μs	20.2ns	78.3ns	0.0381	0	2.14 KB
master	`EncodeLegacyArgs`	netcoreapp3.1	105μs	183ns	658ns	0	0	2.14 KB
master	`EncodeLegacyArgs`	net472	153μs	68ns	263ns	0.306	0	2.15 KB
#6591	`EncodeArgs`	net6.0	37.6μs	18.4ns	68.9ns	0.454	0	32.4 KB
#6591	`EncodeArgs`	netcoreapp3.1	54μs	13.6ns	51ns	0.431	0	32.4 KB
#6591	`EncodeArgs`	net472	67.5μs	71.2ns	276ns	5.16	0.0675	32.5 KB
#6591	`EncodeLegacyArgs`	net6.0	75.4μs	31.9ns	115ns	0	0	2.14 KB
#6591	`EncodeLegacyArgs`	netcoreapp3.1	106μs	132ns	495ns	0	0	2.14 KB
#6591	`EncodeLegacyArgs`	net472	153μs	118ns	457ns	0.309	0	2.15 KB

Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunWafRealisticBenchmark`	net6.0	175μs	118ns	459ns	0	2.44 KB
master	`RunWafRealisticBenchmark`	netcoreapp3.1	187μs	292ns	1.13μs	0	2.39 KB
master	`RunWafRealisticBenchmark`	net472	200μs	62.1ns	240ns	0.299	2.46 KB
master	`RunWafRealisticBenchmarkWithAttack`	net6.0	115μs	45.7ns	177ns	0	1.47 KB
master	`RunWafRealisticBenchmarkWithAttack`	netcoreapp3.1	122μs	98.2ns	380ns	0	1.46 KB
master	`RunWafRealisticBenchmarkWithAttack`	net472	133μs	40.7ns	152ns	0.198	1.49 KB
#6591	`RunWafRealisticBenchmark`	net6.0	176μs	135ns	524ns	0	2.44 KB
#6591	`RunWafRealisticBenchmark`	netcoreapp3.1	187μs	521ns	2.02μs	0	2.39 KB
#6591	`RunWafRealisticBenchmark`	net472	199μs	82.8ns	321ns	0.299	2.46 KB
#6591	`RunWafRealisticBenchmarkWithAttack`	net6.0	116μs	71.7ns	278ns	0	1.47 KB
#6591	`RunWafRealisticBenchmarkWithAttack`	netcoreapp3.1	123μs	51.7ns	186ns	0	1.46 KB
#6591	`RunWafRealisticBenchmarkWithAttack`	net472	132μs	62.6ns	242ns	0.199	1.49 KB

Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #6591

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472	62.09 KB	59.26 KB	-2.82 KB	-4.55%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Allocated
master	`StringConcatBenchmark`	net6.0	56.2μs	613ns	6.07μs	43.44 KB
master	`StringConcatBenchmark`	netcoreapp3.1	53.6μs	233ns	839ns	42.64 KB
master	`StringConcatBenchmark`	net472	37.2μs	88ns	305ns	62.09 KB
master	`StringConcatAspectBenchmark`	net6.0	311μs	1.43μs	5.53μs	265.54 KB
master	`StringConcatAspectBenchmark`	netcoreapp3.1	335μs	1.87μs	11.5μs	253.45 KB
master	`StringConcatAspectBenchmark`	net472	295μs	5.31μs	51.4μs	278.53 KB
#6591	`StringConcatBenchmark`	net6.0	58.5μs	798ns	7.98μs	43.44 KB
#6591	`StringConcatBenchmark`	netcoreapp3.1	62.4μs	820ns	8.08μs	42.64 KB
#6591	`StringConcatBenchmark`	net472	37.6μs	75.3ns	282ns	59.26 KB
#6591	`StringConcatAspectBenchmark`	net6.0	314μs	1.09μs	6.82μs	264.94 KB
#6591	`StringConcatAspectBenchmark`	netcoreapp3.1	350μs	1.74μs	11.1μs	254.23 KB
#6591	`StringConcatAspectBenchmark`	net472	283μs	7.63μs	74μs	278.53 KB

github-actions · 2025-01-24T15:46:49Z

Snapshots difference summary

The following differences have been observed in committed snapshots. It is meant to help the reviewer.
The diff is simplistic, so please check some files anyway while we improve it.

1 occurrences of :

-      _dd.appsec.s.res.headers: [{}],

anna-git requested review from a team as code owners January 24, 2025 13:07

anna-git added 3 commits January 24, 2025 14:26

Change the way we collect ip:

edf7a91

- if custom header doesnt return anything, dont fallback on other ips - enable nullable - remove x-forwarded which is deprecated

Refactor and add unit test for custom ip header returning null

f567b8b

nullability file

e26602c

anna-git force-pushed the anna/amend-ip-collection-secscan branch from 6ea2278 to e26602c Compare January 24, 2025 13:28

headers aren't added if they're empty

df87607

anna-git force-pushed the anna/amend-ip-collection-secscan branch from c862058 to df87607 Compare January 24, 2025 16:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change the way we collect ip and header #6591

Change the way we collect ip and header #6591

anna-git commented Jan 24, 2025 •

edited

Loading

andrewlock commented Jan 24, 2025 •

edited

Loading

datadog-ddstaging bot commented Jan 24, 2025 •

edited

Loading

andrewlock commented Jan 24, 2025 •

edited

Loading

Raw results

Raw results

Raw results

Fewer allocations 🎉 in #6591

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6591

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #6591

Raw results

Raw results

andrewlock commented Jan 24, 2025 •

edited

Loading

Slower ⚠️ in #6591

Faster 🎉 in #6591

Raw results

Raw results

Raw results

Fewer allocations 🎉 in #6591

Raw results

github-actions bot commented Jan 24, 2025

Change the way we collect ip and header #6591

Are you sure you want to change the base?

Change the way we collect ip and header #6591

Conversation

anna-git commented Jan 24, 2025 • edited Loading

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

andrewlock commented Jan 24, 2025 • edited Loading

Execution-Time Benchmarks Report ⏱️

datadog-ddstaging bot commented Jan 24, 2025 • edited Loading

Datadog Report

⌛ Performance Regressions vs Default Branch (1)

andrewlock commented Jan 24, 2025 • edited Loading

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Fewer allocations 🎉 in #6591

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6591

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #6591

Raw results

Raw results

andrewlock commented Jan 24, 2025 • edited Loading

Benchmarks Report for appsec 🐌

Benchmark details

Slower ⚠️ in #6591

Faster 🎉 in #6591

Raw results

Raw results

Raw results

Fewer allocations 🎉 in #6591

Raw results

github-actions bot commented Jan 24, 2025

Snapshots difference summary

anna-git commented Jan 24, 2025 •

edited

Loading

andrewlock commented Jan 24, 2025 •

edited

Loading

datadog-ddstaging bot commented Jan 24, 2025 •

edited

Loading

andrewlock commented Jan 24, 2025 •

edited

Loading

andrewlock commented Jan 24, 2025 •

edited

Loading