Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when using deprecated process_config.enabled #32880

Merged

Conversation

elliterate
Copy link
Contributor

@elliterate elliterate commented Jan 10, 2025

What does this PR do?

Changes the deprecation message log level from INFO to WARN.

Motivation

https://datadoghq.atlassian.net/browse/CTK-4640

Describe how you validated your changes

Manually validated by:

  1. setting process_config.enabled in the agent configuration to "true", e.g.,:

    cat <<-YAML >> /etc/datadog-agent/datadog.yaml
    process_config:
      enabled: "true"
  2. starting the agent with datadog-agent run, and

  3. visually confirming the log level in the output.

image

Possible Drawbacks / Trade-offs

Additional Notes

@bits-bot
Copy link
Collaborator

bits-bot commented Jan 10, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added short review PR is simple enough to be reviewed quickly team/container-intake fka Processes labels Jan 10, 2025
@elliterate elliterate added the qa/done QA done before merge and regressions are covered by tests label Jan 10, 2025
@agent-platform-auto-pr
Copy link
Contributor

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=52728909 --os-family=ubuntu

Note: This applies to commit be98efc

@agent-platform-auto-pr
Copy link
Contributor

Uncompressed package size comparison

Comparison with ancestor 17111e224cc9ac7381802e442b604c37bee63eda

Diff per package
package diff status size ancestor threshold
datadog-agent-arm64-deb 0.00MB 939.28MB 939.28MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 58.83MB 58.83MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 58.90MB 58.90MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 58.90MB 58.90MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 56.33MB 56.33MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 506.82MB 506.82MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 114.20MB 114.20MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 114.27MB 114.27MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 114.27MB 114.27MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 109.63MB 109.63MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 109.69MB 109.69MB 0.50MB
datadog-agent-aarch64-rpm -0.00MB 948.58MB 948.58MB 0.50MB
datadog-agent-x86_64-rpm -0.03MB 1018.81MB 1018.84MB 0.50MB
datadog-agent-x86_64-suse -0.03MB 1018.81MB 1018.84MB 0.50MB
datadog-agent-amd64-deb -0.03MB 1009.49MB 1009.52MB 0.50MB

Decision

✅ Passed

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 794ffffe-4fcd-4edc-bd39-7ff7af757de5

Baseline: 17111e2
Comparison: be98efc
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +1.21 [-1.99, +4.41] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.95 [+0.24, +1.66] 1 Logs
file_tree memory utilization +0.56 [+0.42, +0.69] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.20 [-0.59, +0.99] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.15 [-0.31, +0.62] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.06 [-0.58, +0.69] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.02 [-0.09, +0.12] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.01 [-0.01, +0.02] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.00 [-0.94, +0.94] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.01 [-0.87, +0.85] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.02 [-0.69, +0.65] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.07 [-0.85, +0.70] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput -0.08 [-1.00, +0.84] 1 Logs
quality_gate_idle_all_features memory utilization -0.33 [-0.42, -0.24] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization -0.39 [-0.42, -0.36] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput -0.63 [-0.70, -0.56] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@elliterate elliterate marked this pull request as ready for review January 13, 2025 14:49
@elliterate elliterate requested a review from a team as a code owner January 13, 2025 14:49
@elliterate elliterate self-assigned this Jan 13, 2025
@elliterate
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 13, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-13 16:18:44 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 35m.


2025-01-13 16:54:57 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit dc5ff59 into main Jan 13, 2025
243 of 246 checks passed
@dd-mergequeue dd-mergequeue bot deleted the ian.lesperance/CTK-4640-process-config-enabled-warn branch January 13, 2025 16:54
@github-actions github-actions bot added this to the 7.63.0 milestone Jan 13, 2025
@robertjli robertjli added qa/no-code-change No code change in Agent code requiring validation and removed qa/done QA done before merge and regressions are covered by tests labels Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/container-intake fka Processes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants