enable diagnose port conflict on windows

[mwdd146980]

What does this PR do?

Add windows compatibility for the diagnose port conflict suite. This builds on [PR#25209 (https://github.com//pull/25209).

Created new PR because I messed up my commits from [PR#27457] (#27457).

Motivation

Making this feature available for Windows makes this feature available on all OSes.

Describe how to test/QA your changes

Check that the diagnose suite works properly for Windows:

• when the agent isn't running and there is no port issue
• when the agent is running and there is no port issue (the agent is detected as being the agent, so no issue is raised)
• when some port is used by another process, it is reported
  You can use netcat to bind to a port:

netcat -nvlp 6062

Reviewer's Checklist

• If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
• Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
• A release note has been added or the changelog/no-changelog label has been applied.
• Changed code has automated tests for its functionality.
• Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
• At least one team/.. label has been applied, indicating the team(s) that should QA this change.
• If applicable, docs team has been notified or an issue has been opened on the documentation repo.
• If applicable, the need-change/operator and need-change/helm labels have been applied.
• If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
• If applicable, the config template has been updated.

[cit-pr-commenter]

Go Package Import Differences

Baseline: 4269c6c
Comparison: b65cc73

binary	os	arch	change
security-agent	windows	amd64	+1, -0 +golang.org/x/sys/cpu

[agent-platform-auto-pr]

Uncompressed package size comparison

Comparison with ancestor 4269c6c2328103fe99a56bfb00ac9d9e44130d79

Diff per package

package	diff	status	size	ancestor	threshold
datadog-iot-agent-x86_64-rpm	0.00MB	✅	94.07MB	94.07MB	0.50MB
datadog-iot-agent-x86_64-suse	0.00MB	✅	94.06MB	94.06MB	0.50MB
datadog-agent-amd64-deb	0.00MB	✅	929.16MB	929.16MB	0.50MB
datadog-agent-x86_64-rpm	0.00MB	✅	938.82MB	938.82MB	0.50MB
datadog-agent-x86_64-suse	0.00MB	✅	938.82MB	938.82MB	0.50MB
datadog-agent-arm64-deb	0.00MB	✅	915.82MB	915.82MB	0.50MB
datadog-agent-aarch64-rpm	0.00MB	✅	925.46MB	925.46MB	0.50MB
datadog-dogstatsd-amd64-deb	0.00MB	✅	58.93MB	58.93MB	0.50MB
datadog-dogstatsd-x86_64-rpm	0.00MB	✅	59.01MB	59.01MB	0.50MB
datadog-dogstatsd-x86_64-suse	0.00MB	✅	59.01MB	59.01MB	0.50MB
datadog-dogstatsd-arm64-deb	0.00MB	✅	56.44MB	56.44MB	0.50MB
datadog-heroku-agent-amd64-deb	0.00MB	✅	477.44MB	477.44MB	0.50MB
datadog-iot-agent-amd64-deb	0.00MB	✅	94.00MB	94.00MB	0.50MB
datadog-iot-agent-aarch64-rpm	-0.00MB	✅	90.11MB	90.11MB	0.50MB
datadog-iot-agent-arm64-deb	-0.00MB	✅	90.04MB	90.04MB	0.50MB

Decision

✅ Passed

[agent-platform-auto-pr]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=53624987 --os-family=ubuntu

Note: This applies to commit b65cc73

[cit-pr-commenter]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: ff35096e-f010-4fdd-b604-bddf7922ba82

Baseline: 4269c6c
Comparison: b65cc73
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+0.55	[-0.16, +1.27]	1	Logs
➖	file_tree	memory utilization	+0.43	[+0.27, +0.59]	1	Logs
➖	quality_gate_idle	memory utilization	+0.14	[+0.10, +0.18]	1	Logs bounds checks dashboard
➖	quality_gate_idle_all_features	memory utilization	+0.11	[+0.03, +0.19]	1	Logs bounds checks dashboard
➖	file_to_blackhole_500ms_latency	egress throughput	+0.06	[-0.73, +0.85]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.03	[-0.73, +0.79]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	+0.02	[-0.62, +0.66]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.01	[-0.77, +0.79]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.01, +0.02]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.01	[-0.11, +0.10]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.02	[-0.86, +0.81]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	-0.04	[-0.91, +0.83]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	-0.06	[-0.89, +0.76]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	-0.20	[-0.67, +0.26]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-1.62	[-1.68, -1.56]	1	Logs
➖	quality_gate_logs	% cpu utilization	-2.49	[-5.60, +0.61]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10
✅	quality_gate_logs	lost_bytes	10/10
✅	quality_gate_logs	memory_usage	10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.

[pgimalac]

I didn't review the windows-specific code in depth, LGTM as long as it works as expected and the e2e test passes 👍

[gabedos]

Looks good as before

[mwdd146980]

/merge

[dd-devflow]

Devflow running: /merge

View all feedbacks in Devflow UI.

---

2025-01-22 00:16:55 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 34m.

---

2025-01-22 01:12:08 UTC ℹ️ MergeQueue: This merge request was merged