Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CWS] add a new opts to accessor generator to only generate needed field accessors #32873

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

paulcacheux
Copy link
Contributor

What does this PR do?

Currently we generate field accessors for all fields, but we only use a small subset of those. This PR allows to specify the required ones, and generate only those. This is mostly done with code size in mind.

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@paulcacheux paulcacheux added changelog/no-changelog team/agent-security qa/done QA done before merge and regressions are covered by tests labels Jan 10, 2025
@paulcacheux paulcacheux requested a review from a team as a code owner January 10, 2025 17:25
@github-actions github-actions bot added component/system-probe long review PR is complex, plan time to review it labels Jan 10, 2025
Copy link

cit-pr-commenter bot commented Jan 10, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 84e93d1d-a528-4748-a0b8-696f2b758f9b

Baseline: e61a162
Comparison: 4efdefa
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +2.16 [-1.06, +5.38] 1 Logs
tcp_syslog_to_blackhole ingress throughput +1.50 [+1.43, +1.57] 1 Logs
file_tree memory utilization +0.27 [+0.14, +0.41] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.22 [-0.25, +0.69] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.18 [-0.60, +0.96] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.09 [-0.77, +0.95] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.00 [-0.87, +0.87] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.00 [-0.68, +0.69] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.11, +0.10] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.01 [-0.65, +0.63] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.03 [-0.92, +0.87] 1 Logs
quality_gate_idle_all_features memory utilization -0.04 [-0.13, +0.04] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency egress throughput -0.13 [-0.92, +0.67] 1 Logs
quality_gate_idle memory utilization -0.22 [-0.27, -0.18] 1 Logs bounds checks dashboard
uds_dogstatsd_to_api_cpu % cpu utilization -0.87 [-1.58, -0.16] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@paulcacheux paulcacheux force-pushed the paulcacheux/swap-getters branch from 20588bb to 7bdc054 Compare January 10, 2025 18:22
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 10, 2025

Uncompressed package size comparison

Comparison with ancestor e61a162ae8c382ba422d9df93cdf557727dd5a24

Diff per package
package diff status size ancestor threshold
datadog-dogstatsd-amd64-deb 0.00MB 58.83MB 58.83MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 58.90MB 58.90MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 58.90MB 58.90MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 56.33MB 56.33MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 506.82MB 506.82MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 114.20MB 114.20MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 114.27MB 114.27MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 114.27MB 114.27MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 109.63MB 109.63MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 109.69MB 109.69MB 0.50MB
datadog-agent-arm64-deb -1.57MB 937.71MB 939.28MB 0.50MB
datadog-agent-aarch64-rpm -1.57MB 947.01MB 948.58MB 0.50MB
datadog-agent-amd64-deb -1.86MB 1007.63MB 1009.49MB 0.50MB
datadog-agent-x86_64-rpm -1.86MB 1016.95MB 1018.81MB 0.50MB
datadog-agent-x86_64-suse -1.86MB 1016.95MB 1018.81MB 0.50MB

Decision

✅ Passed

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 10, 2025

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=52724122 --os-family=ubuntu

Note: This applies to commit 4efdefa

@paulcacheux paulcacheux force-pushed the paulcacheux/swap-getters branch from 7bdc054 to cf8cc2e Compare January 10, 2025 19:09
@paulcacheux paulcacheux force-pushed the paulcacheux/swap-getters branch from cf8cc2e to 4efdefa Compare January 10, 2025 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog component/system-probe long review PR is complex, plan time to review it qa/done QA done before merge and regressions are covered by tests team/agent-security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant