Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move oracle check to checks-agent #32871

Draft
wants to merge 2 commits into
base: checks-agent-process
Choose a base branch
from

Conversation

pgimalac
Copy link
Member

What does this PR do?

This is just to get numbers from SMP.

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

The cluster agent imports k8s related packages that not all flavors of the agent require.

With this change we attempt to remove certain packages from non cluster agent flavors.

GustavoCaso and others added 2 commits January 10, 2025 16:04
The cluster agent imports k8s related packages that not all flavors of the agent require.
With this change we attempt to remove certain packages from non cluster agent flavors.
Copy link

Go Package Import Differences

Baseline: 49022d2
Comparison: 9e14536

binaryosarchchange
agentlinuxamd64
+0, -25
-github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle
-github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle/common
-github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle/config
-github.com/DataDog/datadog-agent/pkg/status/render
-github.com/go-logfmt/logfmt
-github.com/godror/godror
-github.com/godror/godror/dsn
-github.com/godror/knownpb/internal
-github.com/godror/knownpb/timestamppb
-github.com/jmoiron/sqlx
-github.com/jmoiron/sqlx/reflectx
-github.com/sijms/go-ora/v2
-github.com/sijms/go-ora/v2/advanced_nego
-github.com/sijms/go-ora/v2/advanced_nego/ntlmssp
-github.com/sijms/go-ora/v2/configurations
-github.com/sijms/go-ora/v2/converters
-github.com/sijms/go-ora/v2/network
-github.com/sijms/go-ora/v2/network/security
-github.com/sijms/go-ora/v2/network/security/md4
-github.com/sijms/go-ora/v2/trace
-go/constant
-go/types
-go/version
-internal/gover
-internal/types/errors
agentlinuxarm64
+0, -25
-github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle
-github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle/common
-github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle/config
-github.com/DataDog/datadog-agent/pkg/status/render
-github.com/go-logfmt/logfmt
-github.com/godror/godror
-github.com/godror/godror/dsn
-github.com/godror/knownpb/internal
-github.com/godror/knownpb/timestamppb
-github.com/jmoiron/sqlx
-github.com/jmoiron/sqlx/reflectx
-github.com/sijms/go-ora/v2
-github.com/sijms/go-ora/v2/advanced_nego
-github.com/sijms/go-ora/v2/advanced_nego/ntlmssp
-github.com/sijms/go-ora/v2/configurations
-github.com/sijms/go-ora/v2/converters
-github.com/sijms/go-ora/v2/network
-github.com/sijms/go-ora/v2/network/security
-github.com/sijms/go-ora/v2/network/security/md4
-github.com/sijms/go-ora/v2/trace
-go/constant
-go/types
-go/version
-internal/gover
-internal/types/errors
agentwindowsamd64
+0, -27
-github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle
-github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle/common
-github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle/config
-github.com/DataDog/datadog-agent/pkg/status/render
-github.com/go-logfmt/logfmt
-github.com/godror/godror
-github.com/godror/godror/dsn
-github.com/godror/knownpb/internal
-github.com/godror/knownpb/timestamppb
-github.com/jmoiron/sqlx
-github.com/jmoiron/sqlx/reflectx
-github.com/sijms/go-ora/v2
-github.com/sijms/go-ora/v2/advanced_nego
-github.com/sijms/go-ora/v2/advanced_nego/ntlmssp
-github.com/sijms/go-ora/v2/configurations
-github.com/sijms/go-ora/v2/converters
-github.com/sijms/go-ora/v2/network
-github.com/sijms/go-ora/v2/network/security
-github.com/sijms/go-ora/v2/network/security/md4
-github.com/sijms/go-ora/v2/trace
-go/constant
-go/types
-go/version
-internal/buildcfg
-internal/gover
-internal/goversion
-internal/types/errors
agentdarwinamd64
+0, -27
-github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle
-github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle/common
-github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle/config
-github.com/DataDog/datadog-agent/pkg/status/render
-github.com/go-logfmt/logfmt
-github.com/godror/godror
-github.com/godror/godror/dsn
-github.com/godror/knownpb/internal
-github.com/godror/knownpb/timestamppb
-github.com/jmoiron/sqlx
-github.com/jmoiron/sqlx/reflectx
-github.com/sijms/go-ora/v2
-github.com/sijms/go-ora/v2/advanced_nego
-github.com/sijms/go-ora/v2/advanced_nego/ntlmssp
-github.com/sijms/go-ora/v2/configurations
-github.com/sijms/go-ora/v2/converters
-github.com/sijms/go-ora/v2/network
-github.com/sijms/go-ora/v2/network/security
-github.com/sijms/go-ora/v2/network/security/md4
-github.com/sijms/go-ora/v2/trace
-go/constant
-go/types
-go/version
-internal/buildcfg
-internal/gover
-internal/goversion
-internal/types/errors
agentdarwinarm64
+0, -27
-github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle
-github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle/common
-github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle/config
-github.com/DataDog/datadog-agent/pkg/status/render
-github.com/go-logfmt/logfmt
-github.com/godror/godror
-github.com/godror/godror/dsn
-github.com/godror/knownpb/internal
-github.com/godror/knownpb/timestamppb
-github.com/jmoiron/sqlx
-github.com/jmoiron/sqlx/reflectx
-github.com/sijms/go-ora/v2
-github.com/sijms/go-ora/v2/advanced_nego
-github.com/sijms/go-ora/v2/advanced_nego/ntlmssp
-github.com/sijms/go-ora/v2/configurations
-github.com/sijms/go-ora/v2/converters
-github.com/sijms/go-ora/v2/network
-github.com/sijms/go-ora/v2/network/security
-github.com/sijms/go-ora/v2/network/security/md4
-github.com/sijms/go-ora/v2/trace
-go/constant
-go/types
-go/version
-internal/buildcfg
-internal/gover
-internal/goversion
-internal/types/errors
iot-agentlinuxamd64
+0, -3
-github.com/DataDog/datadog-agent/pkg/clusteragent/autoscaling/custommetrics
-github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle
-github.com/DataDog/datadog-agent/pkg/status/render
iot-agentlinuxarm64
+0, -3
-github.com/DataDog/datadog-agent/pkg/clusteragent/autoscaling/custommetrics
-github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle
-github.com/DataDog/datadog-agent/pkg/status/render
heroku-agentlinuxamd64
+0, -3
-github.com/DataDog/datadog-agent/pkg/clusteragent/autoscaling/custommetrics
-github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle
-github.com/DataDog/datadog-agent/pkg/status/render
cluster-agentlinuxamd64
+1, -1
-github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle
+github.com/DataDog/datadog-agent/pkg/flare/clusteragent
cluster-agentlinuxarm64
+1, -1
-github.com/DataDog/datadog-agent/pkg/collector/corechecks/oracle
+github.com/DataDog/datadog-agent/pkg/flare/clusteragent
cluster-agent-cloudfoundrylinuxamd64
+1, -0
+github.com/DataDog/datadog-agent/pkg/flare/clusteragent
cluster-agent-cloudfoundrylinuxarm64
+1, -0
+github.com/DataDog/datadog-agent/pkg/flare/clusteragent
security-agentlinuxamd64
+0, -59
-github.com/DataDog/datadog-agent/pkg/clusteragent/autoscaling/custommetrics
-github.com/DataDog/datadog-agent/pkg/status/render
-github.com/DataDog/datadog-agent/pkg/util/kubernetes/apiserver/leaderelection/metrics
-github.com/blang/semver/v4
-github.com/grpc-ecosystem/grpc-gateway/v2/internal/httprule
-github.com/grpc-ecosystem/grpc-gateway/v2/runtime
-github.com/grpc-ecosystem/grpc-gateway/v2/utilities
-go.opentelemetry.io/otel/exporters/otlp/otlptrace
-go.opentelemetry.io/otel/exporters/otlp/otlptrace/internal/tracetransform
-go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc
-go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc/internal
-go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc/internal/envconfig
-go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc/internal/otlpconfig
-go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc/internal/retry
-go.opentelemetry.io/otel/semconv/v1.17.0
-go.opentelemetry.io/proto/otlp/collector/trace/v1
-go.opentelemetry.io/proto/otlp/common/v1
-go.opentelemetry.io/proto/otlp/resource/v1
-go.opentelemetry.io/proto/otlp/trace/v1
-google.golang.org/genproto/googleapis/rpc/errdetails
-google.golang.org/grpc/encoding/gzip
-google.golang.org/protobuf/types/known/structpb
-k8s.io/apimachinery/pkg/api/validation/path
-k8s.io/apimachinery/pkg/util/rand
-k8s.io/apimachinery/pkg/util/uuid
-k8s.io/apimachinery/pkg/util/version
-k8s.io/apiserver/pkg/admission
-k8s.io/apiserver/pkg/apis/apiserver
-k8s.io/apiserver/pkg/apis/apiserver/v1
-k8s.io/apiserver/pkg/apis/audit
-k8s.io/apiserver/pkg/apis/audit/v1
-k8s.io/apiserver/pkg/audit
-k8s.io/apiserver/pkg/authentication/user
-k8s.io/apiserver/pkg/authorization/authorizer
-k8s.io/apiserver/pkg/endpoints/discovery
-k8s.io/apiserver/pkg/endpoints/handlers/negotiation
-k8s.io/apiserver/pkg/endpoints/handlers/responsewriters
-k8s.io/apiserver/pkg/endpoints/metrics
-k8s.io/apiserver/pkg/endpoints/request
-k8s.io/apiserver/pkg/endpoints/responsewriter
-k8s.io/apiserver/pkg/features
-k8s.io/apiserver/pkg/registry/rest
-k8s.io/apiserver/pkg/storage
-k8s.io/apiserver/pkg/storage/names
-k8s.io/apiserver/pkg/util/feature
-k8s.io/apiserver/pkg/util/flushwriter
-k8s.io/apiserver/pkg/warning
-k8s.io/component-base/featuregate
-k8s.io/component-base/metrics
-k8s.io/component-base/metrics/legacyregistry
-k8s.io/component-base/metrics/prometheus/feature
-k8s.io/component-base/metrics/prometheusextension
-k8s.io/component-base/tracing
-k8s.io/component-base/tracing/api/v1
-k8s.io/component-base/version
-k8s.io/metrics/pkg/apis/custom_metrics
-k8s.io/metrics/pkg/apis/external_metrics
-sigs.k8s.io/custom-metrics-apiserver/pkg/provider
-sigs.k8s.io/custom-metrics-apiserver/pkg/provider/defaults
security-agentlinuxarm64
+0, -59
-github.com/DataDog/datadog-agent/pkg/clusteragent/autoscaling/custommetrics
-github.com/DataDog/datadog-agent/pkg/status/render
-github.com/DataDog/datadog-agent/pkg/util/kubernetes/apiserver/leaderelection/metrics
-github.com/blang/semver/v4
-github.com/grpc-ecosystem/grpc-gateway/v2/internal/httprule
-github.com/grpc-ecosystem/grpc-gateway/v2/runtime
-github.com/grpc-ecosystem/grpc-gateway/v2/utilities
-go.opentelemetry.io/otel/exporters/otlp/otlptrace
-go.opentelemetry.io/otel/exporters/otlp/otlptrace/internal/tracetransform
-go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc
-go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc/internal
-go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc/internal/envconfig
-go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc/internal/otlpconfig
-go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc/internal/retry
-go.opentelemetry.io/otel/semconv/v1.17.0
-go.opentelemetry.io/proto/otlp/collector/trace/v1
-go.opentelemetry.io/proto/otlp/common/v1
-go.opentelemetry.io/proto/otlp/resource/v1
-go.opentelemetry.io/proto/otlp/trace/v1
-google.golang.org/genproto/googleapis/rpc/errdetails
-google.golang.org/grpc/encoding/gzip
-google.golang.org/protobuf/types/known/structpb
-k8s.io/apimachinery/pkg/api/validation/path
-k8s.io/apimachinery/pkg/util/rand
-k8s.io/apimachinery/pkg/util/uuid
-k8s.io/apimachinery/pkg/util/version
-k8s.io/apiserver/pkg/admission
-k8s.io/apiserver/pkg/apis/apiserver
-k8s.io/apiserver/pkg/apis/apiserver/v1
-k8s.io/apiserver/pkg/apis/audit
-k8s.io/apiserver/pkg/apis/audit/v1
-k8s.io/apiserver/pkg/audit
-k8s.io/apiserver/pkg/authentication/user
-k8s.io/apiserver/pkg/authorization/authorizer
-k8s.io/apiserver/pkg/endpoints/discovery
-k8s.io/apiserver/pkg/endpoints/handlers/negotiation
-k8s.io/apiserver/pkg/endpoints/handlers/responsewriters
-k8s.io/apiserver/pkg/endpoints/metrics
-k8s.io/apiserver/pkg/endpoints/request
-k8s.io/apiserver/pkg/endpoints/responsewriter
-k8s.io/apiserver/pkg/features
-k8s.io/apiserver/pkg/registry/rest
-k8s.io/apiserver/pkg/storage
-k8s.io/apiserver/pkg/storage/names
-k8s.io/apiserver/pkg/util/feature
-k8s.io/apiserver/pkg/util/flushwriter
-k8s.io/apiserver/pkg/warning
-k8s.io/component-base/featuregate
-k8s.io/component-base/metrics
-k8s.io/component-base/metrics/legacyregistry
-k8s.io/component-base/metrics/prometheus/feature
-k8s.io/component-base/metrics/prometheusextension
-k8s.io/component-base/tracing
-k8s.io/component-base/tracing/api/v1
-k8s.io/component-base/version
-k8s.io/metrics/pkg/apis/custom_metrics
-k8s.io/metrics/pkg/apis/external_metrics
-sigs.k8s.io/custom-metrics-apiserver/pkg/provider
-sigs.k8s.io/custom-metrics-apiserver/pkg/provider/defaults
security-agentwindowsamd64
+0, -1
-github.com/DataDog/datadog-agent/pkg/status/render

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants