-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for .openhands/setup.sh script #5985
base: main
Are you sure you want to change the base?
Conversation
@rbren gentle ping to see if this is on your radar |
Yup still want to get this done! Haven't had time to test yet though |
@openhands-agent can you fix the merge conflicts? Look at diff vs main and understand the conflicts first |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to confirm, if the setup.sh
script takes a long time to run, what does it look like in the frontend?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍰
@@ -223,6 +223,7 @@ async def _create_runtime( | |||
repo_directory = await call_sync_from_async( | |||
self.runtime.clone_repo, github_token, selected_repository | |||
) | |||
await call_sync_from_async(self.runtime.maybe_run_setup_script) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a session is restored, this will run a second/third time, even though the sandbox was restarted and not created? Not sure, and I didn't try it, it looks that way from the code.
(it's the status quo for clone_repo
too, so not an issue for this PR, just seems worth thinking if this is the right behavior)
This PR adds support for running
.openhands/setup.sh
after runtime initialization.The setup script is run in the runtime environment, similar to how other runtime operations work.
To run this PR locally, use the following command: