-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue #5965: [Bug]: Misc UI issues due to resizable and collapsible panel #5966
Conversation
The code changes so far do fix the issue when I open OpenHands in a weird aspect ratio screen that I used to do. It looks good on a large screen. However, I'm still able to drag each panel to be very small and make it doesn't look good. @openhands-agent Can you look into it? |
… and collapsible panel
Status Overview: ✅ Progress Made:
❌ Remaining Issues:
Recommended Next Steps:
Summary: While initial improvements were made, the core usability issues persist. Further adjustments to the implementation are needed to fully resolve the panel sizing problems. |
You should first read the "diff" against main to understand existing implementation, then check the history of this thread. |
… and collapsible panel
Concise Overview: Status: PARTIALLY RESOLVED with remaining issues Completed: Remaining Issues:
Next Steps Required:
Recommendation: Issue should remain open until panel sizing behavior is fully fixed and verified. |
OpenHands you need to run |
… and collapsible panel
Summary of Issue Status: UNRESOLVED - Panel Sizing Issues Current State:
Required for Resolution:
Recommendation: |
OpenHands -- resize the box will actually change the min-width. The current setup doesn't really prevent the panel from being resized too much. Can you help? |
… and collapsible panel
Status Summary: UNRESOLVED - Panel Sizing Issues Key Points:
Recommendation:
|
ok OpenHands - this looks MUCH better! Now there are several issues:
|
… and collapsible panel
Status Overview: Pending Issues:
Current State: Recommendation:
Overall Status: UNRESOLVED - Pending reviewer confirmation |
… and collapsible panel
Status Overview: ❌ UNRESOLVED ISSUES:
NEXT STEPS REQUIRED:
SUMMARY: |
- Fix right panel extending beyond browser window - Fix terminal panel not filling available space - Adjust chat panel max width to 50% - Simplify resize logic using React state - Add proper flex properties for responsive behavior
- Remove window resize handling since panels use flex layout - Use fixed min/max dimensions instead of window-based constraints - Keep proportional sizing for second panel (30-70%)
da96e04
to
dcb24d3
Compare
- Keep responsive layout with flex-col/flex-row - Keep hover states for better UX - Keep test IDs for better test stability - Keep Delete text for clearer action - Keep font-bold from main branch
Can't get this to work well 😓 gonna close this for now |
This PR fixes an issue with the resizable panel component where the right panel would overflow outside the browser border when the left chat panel is expanded to its maximum width (50%).
Changes made:
minWidth
changed from600px
to30%
maxWidth: "70%"
to ensure the panel stays within boundsmaxWidth: "50%"
These changes ensure:
The changes have been tested locally and all tests pass.
To run this PR locally, use the following command: