Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wpimath] Implement Pose2d and Pose3d rotateAround() #7659

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

[wpimath] Implement Pose2d and Pose3d rotateAround() #7659

wants to merge 13 commits into from
+98 −0

Conversation

TheComputer314
Copy link
Contributor

@TheComputer314 TheComputer314 commented Jan 8, 2025 •
edited
Loading

Closes #7657

@github-actions github-actions bot added the component: wpimath Math library label Jan 8, 2025
@TheComputer314 TheComputer314 changed the title Implement Pose2d and Pose3d rotateAround() [wpimath] Implement Pose2d and Pose3d rotateAround() Jan 10, 2025
@TheComputer314 TheComputer314 marked this pull request as ready for review January 10, 2025 16:26
@TheComputer314 TheComputer314 requested a review from a team as a code owner January 10, 2025 16:26
calcmogul
calcmogul requested changes Jan 10, 2025
View reviewed changes
Copy link
Member

@calcmogul calcmogul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just needs unit tests.

@TheComputer314
Copy link
Contributor Author

Looks good. Just needs unit tests.

Done.

calcmogul
calcmogul previously approved these changes Jan 10, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chauser chauser chauser left review comments

@calcmogul calcmogul calcmogul approved these changes

Assignees
No one assigned
Labels
component: wpimath Math library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Pose2d and Pose3d rotateAround()
3 participants
@TheComputer314 @chauser @calcmogul