This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
Allow users to abort before pushing to origin #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added so that origin isn't messed up by the program unintentionally
palemtnrider
suggested changes
Sep 27, 2019
- added git origin url to the prompt - uses variable rather than re-executing the same command - Increase clarity of line 417–steps now mirror order.
This has now been added—only seen after re reading comments.
|
Apologies for not assigning myself and for the late reply.. I didn’t realise this would be an issue :/. I believe I have amended it appropriately. |
palemtnrider
suggested changes
Oct 2, 2019
Comment on lines
+401
to
+402
| GIT_ORIGIN = `git config --get remote.origin.url` | ||
| GIT_BRANCH = `git rev-parse --abbrev-ref HEAD` |
There was a problem hiding this comment.
These aren't valid in bash/zsh. Can you elaborate on how you tested your changes?
There was a problem hiding this comment.
They are, what isn’t valid about them?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34