Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for typed template slots #1253

Closed
johnsoncodehk opened this issue May 3, 2022 · 2 comments
Closed

Support for typed template slots #1253

johnsoncodehk opened this issue May 3, 2022 · 2 comments
Labels
enhancement New feature or request upstream

Comments

@johnsoncodehk
Copy link
Member

Since 0.34.0, typed template slots is not supported due to #1108, we need to wait for vuejs/core#2693 implemented to have a new way to support typed template slots that do not have performance issue.
@johnsoncodehk johnsoncodehk added enhancement New feature or request upstream labels May 3, 2022
@johnsoncodehk johnsoncodehk mentioned this issue May 3, 2022
Closed
@oliverzy
Copy link

oliverzy commented May 8, 2022 •
edited
Loading

Could we make this feature as an option that default as false and add a warning if user want to enable it? Because I see this upstream issue has been opened almost one and half years, typed slot is an very important feature that volar has

@TotomInc
Copy link

I agree with @oliverzy, the best of both worlds would be to make it an option that is turned off by default.

@johnsoncodehk johnsoncodehk mentioned this issue May 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request upstream
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@oliverzy @TotomInc @johnsoncodehk