Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move mongodb to peerDependencies #775

Open
rtritto opened this issue Jul 9, 2023 · 2 comments
Open

Move mongodb to peerDependencies #775

rtritto opened this issue Jul 9, 2023 · 2 comments
Labels
dependencies Pull requests that update a dependency file

Comments

@rtritto
Copy link

rtritto commented Jul 9, 2023

mongodb should be moved from dependencies to peerDependencies.

Context

npm 6 doesn't autoinstall peerDependencies.
npm 6 is used in Node 14 that is deprecated.
npm versions > 6 will autoinstall peerDependencies.
@rtritto rtritto added the bug label Jul 9, 2023
@hasezoey hasezoey added dependencies Pull requests that update a dependency file and removed bug labels Jul 9, 2023
@hasezoey
Copy link
Member

hasezoey commented Jul 9, 2023

why should mongodb be moved to peerDependencies?
any modern package manager will automatically de-duplicate a package if possible and mongodb-memory-server-core does not export any mongodb variables, it is also tested against that version and will not interfere with other installed mongodb versions installed

@rtritto
Copy link
Author

rtritto commented Jul 9, 2023 •
edited
Loading

By this way, can be used a specific version and/or same version in dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hasezoey @rtritto