[FEATURE] gradlew support

[bguedel]

• What are you trying to do?
  Run nexusiq from a gradle built project
• What feature or behavior is this required for?
  Normal project related development
• How could we solve this issue? (Not knowing is okay!)
  Support gradle in the project directory ./gradlew
• Anything else?
  Related Add Gradle support #67 is to ask for gradle support but its most common to have have "gradle" installed but to actually have the wrapper in the project. Often enough people would be working on many projects some of which are not on the same version and thus the gradle wrapper.

It should be noted that I have also tried creating a symlink in my own ~/bin to gradlew named gradle but that is not working.
ln -s "./gradlew" gradle

running in my project

▶ gradle clean build      
executing gradlew instead of gradle
<=------------> 13% EXECUTING [1s]

cc @bhamail / @DarthHater

[bguedel]

i am wondering if this code is expecting to find an executable named gradle in the working directory

vscode-iq-plugin/ext-src/packages/gradle/GradleDependencies.ts

Line 29 in 33010ee

return PackageDependenciesHelper.checkIfValid("build.gradle", "gradle");

if thats the case; this will not work with projects with a wrapper; as the wrapper is in a folder named gradle.

[bguedel]

An example for this could be created by going to
https://start.spring.io

making sure to select gradle (or maven if you want to prove that out as well; it comes with a wrapper).
Select a dependency... say spring-web (has known cve)

this is my example

[bguedel]

Overall thanks to the community; on the gradle plugin, you have already fixed an issue for me :)

sonatype-nexus-community/scan-gradle-plugin#67

[DarthHater]

@bguedel check out #201 , I haven't tested it yet (I will) but that might do the trick.

[bguedel]

Yeah that does look promising.

[DarthHater]

@bguedel I got a chance to test this morning, had to make some changes, but it looks like it's working now. I will go ahead and merge it, if you can give it a test!

[brent-spiner]

🎉 This issue has been resolved in version 1.0.26 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[bguedel]

I dont think ill be able to test until it gets released

[bguedel]

GET OUT OF MY HEAD @brent-spiner

[bguedel]

@DarthHater Looks like it didnt solve it on my end.

[DarthHater]

Interesting! What it's doing is checking to see if the command exists, do you have a gradle alias? etc...?

[bguedel]

not anymore; removed the alias; removed the symlink

[DarthHater]

Interesting. VS Code uses it's own interactive shell, so maybe in that shell there is an alias or something akin?

I just pushed up another commit to main that separates out where it checks for it. I'll add some logging in a bit and see if we can get to the bottom of it!

[DarthHater]

@bguedel there will be a new version released soonish that has logging implemented for the Gradle command stuff. Once that's released, take a look at this section of the README for info on the logger: https://github.com/sonatype-nexus-community/vscode-iq-plugin#development

Set it to INFO and give me the bits that are around Gradle (I don't need anything past this block of info (just trying to see what it is happening more or less in the Gradle muncher):

[bguedel]

sure can we "unclose" this issue so that its not lost in the wrong tab?

[bguedel]

{
  "startTime": "2021-04-16T19:47:32.378Z",
  "categoryName": "sonatypeIQ",
  "data": ["Starting to Munch on GradleDependencies dependencies"],
  "level": {
    "level": 20000,
    "levelStr": "INFO",
    "colour": "green"
  },
  "context": {},
  "pid": 26473
}, {
  "startTime": "2021-04-16T19:47:32.378Z",
  "categoryName": "sonatypeIQ",
  "data": ["Starting to attempt to get gradle dependencies"],
  "level": {
    "level": 10000,
    "levelStr": "DEBUG",
    "colour": "cyan"
  },
  "context": {},
  "pid": 26473
}, {
  "startTime": "2021-04-16T19:47:32.379Z",
  "categoryName": "sonatypeIQ",
  "data": ["Does gradle exist as a command?", true],
  "level": {
    "level": 10000,
    "levelStr": "DEBUG",
    "colour": "cyan"
  },
  "context": {},
  "pid": 26473
}, {
  "startTime": "2021-04-16T19:47:32.379Z",
  "categoryName": "sonatypeIQ",
  "data": ["Set gradle Command Base Command", "gradle"],
  "level": {
    "level": 20000,
    "levelStr": "INFO",
    "colour": "green"
  },
  "context": {},
  "pid": 26473
}, {
  "startTime": "2021-04-16T19:47:32.379Z",
  "categoryName": "sonatypeIQ",
  "data": ["Full gradle command constructed", "gradle dependencies --configuration runtimeClasspath"],
  "level": {
    "level": 20000,
    "levelStr": "INFO",
    "colour": "green"
  },
  "context": {},
  "pid": 26473
}, {
  "startTime": "2021-04-16T19:47:32.380Z",
  "categoryName": "sonatypeIQ",
  "data": ["Attempting to run gradle command", "gradle dependencies --configuration runtimeClasspath"],
  "level": {
    "level": 10000,
    "levelStr": "DEBUG",
    "colour": "cyan"
  },
  "context": {},
  "pid": 26473
}

[DarthHater]

WILD, so it is finding a gradle, at least in that shell. Let me see if I can cook up something else.

[bguedel]

Yeah. A little more debugging on my side and I was right.

i am wondering if this code is expecting to find an executable named gradle in the working directory
vscode-iq-plugin/ext-src/packages/gradle/GradleDependencies.ts

Line 29 in 33010ee

if thats the case; this will not work with projects with a wrapper; as the wrapper is in a folder named gradle.

I renamed the gradle folder to gradlez

{"startTime":"2021-04-16T19:55:18.853Z","categoryName":"sonatypeIQ","data":["Does gradle exist as a command?",false],"level":{"level":10000,"levelStr":"DEBUG","colour":"cyan"},"context":{},"pid":26473},
{"startTime":"2021-04-16T19:55:18.853Z","categoryName":"sonatypeIQ","data":["Operating system determination","darwin"],"level":{"level":20000,"levelStr":"INFO","colour":"green"},"context":{},"pid":26473},
{"startTime":"2021-04-16T19:55:18.854Z","categoryName":"sonatypeIQ","data":["Set gradle Command Base Command","./gradlew"],"level":{"level":20000,"levelStr":"INFO","colour":"green"},"context":{},"pid":26473},

[bguedel]

but then it fails b/c the wrapper tries to call the jar that is in ./gradle/wrapper/gradle-wrapper.jar and the path does not exist b/c its now gradlez.

:(

[DarthHater]

That is wild, that means the library I'm using is hilariously bad.

I'll cook something better up tomorrow, everything worked fine for me locally on OS X, but I am not a gradle power user. I was using the scan-gradle-plugin to test it!

[bguedel]

Hey @DarthHater,
We kind of left this knowing there was a slight issue with a lib you were using.

Any updates on getting a new version in with a better library?

[DarthHater]

@bguedel I had to do a quick trip from Seattle to Alaska via car and it kinda knocked me out of commission, I'm going to look at this a bit more today!

[madpah]

@bguedel - can you check if you still have these issues with version 1.2.3 please? This includes some changes also that prioritise gradlew support over gradle.

Thanks

FYI @DarthHater / @bhamail