Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Remove shadowing #147

Open
guillermo-varela opened this issue Dec 21, 2023 · 0 comments · Fixed by #151
Open

[FEATURE] Remove shadowing #147

guillermo-varela opened this issue Dec 21, 2023 · 0 comments · Fixed by #151
Labels
enhancement New feature or request

Comments

@guillermo-varela
Copy link
Contributor

  • What are you trying to do?
    Simplify and reducing time in the packaging process of this plugin.

In the early days of the plugin its dependency nexus-platform-api was an uber-jar (a JAR file with all its dependencies inside) and that was causing conflicts on some projects' classpaths.

Many versions ago, including the one currently used in the plugin (4.0.3-01) it's no longer an uber-jar with all dependencies in it so we could consider no longer applying the shadow plugin and publish this plugin as a regular JAR file.

  • How could we solve this issue? (Not knowing is okay!)
    Stop using the shadow plugin.

cc @bhamail / @DarthHater / @shaikhu
@guillermo-varela guillermo-varela added the enhancement New feature or request label Dec 21, 2023
@shaikhu shaikhu mentioned this issue Jan 18, 2024
Merged
shaikhu added a commit that referenced this issue May 23, 2024
@shaikhu @guillermo-varela
#147 Drop usage of shadow plugin (#151)
0c01808 
Co-authored-by: Guillermo Varela <[email protected]>
shaikhu added a commit that referenced this issue Aug 28, 2024
@shaikhu @guillermo-varela
#147 Drop usage of shadow plugin (#151)
bbeab7e 
Co-authored-by: Guillermo Varela <[email protected]>
shaikhu added a commit that referenced this issue Oct 10, 2024
@shaikhu @guillermo-varela
#147 Drop usage of shadow plugin (#151)
5f21a3d 
Co-authored-by: Guillermo Varela <[email protected]>
@shaikhu shaikhu mentioned this issue Oct 24, 2024
Merged
shaikhu added a commit that referenced this issue Oct 24, 2024
@shaikhu @guillermo-varela
#147 Drop usage of shadow plugin (#151)
1163e8d 
Co-authored-by: Guillermo Varela <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#147 Drop usage of shadow plugin sonatype-nexus-community/scan-gradle-plugin
1 participant
@guillermo-varela