Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple class names are not added correctly #117

Closed
nichoth opened this issue Oct 19, 2023 · 3 comments
Closed

Multiple class names are not added correctly #117

nichoth opened this issue Oct 19, 2023 · 3 comments

Comments

@nichoth
Copy link
Contributor

nichoth commented Oct 19, 2023

bug report

If you add multiple classes as a variable they are not added correctly. The first class is added, but the following classes are added as attributes to the element.

Steps To Reproduce
See https://github.com/nichoth/tonic/blob/750fceca1c098c9fe413c335797dce2082891391/test/index.js#L15 — a failing test

Expected behavior
Should add the correct class names.
@nichoth nichoth mentioned this issue Oct 19, 2023
Closed
@nichoth nichoth closed this as not planned Won't fix, can't repro, duplicate, stale Oct 20, 2023
@bcomnes
Copy link
Contributor

bcomnes commented Oct 20, 2023

Did this turn out not to be an issue?

@nichoth
Copy link
Contributor Author

nichoth commented Oct 20, 2023

I made a PR, #118 , but I closed it because it's a better solution to use quotes in the instance method, eg class="${abc}", not class=${abc}.

@heapwolf
Copy link
Member

the bug is not adding quotes

@socketsupply socketsupply deleted a comment from nichoth Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix class names substrate-system/tonic
3 participants
@heapwolf @bcomnes @nichoth