Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sydney timezone #265

Open
OrestZborowski-SIG opened this issue Dec 6, 2021 · 1 comment
Open

Add Sydney timezone #265

OrestZborowski-SIG opened this issue Dec 6, 2021 · 1 comment
Labels
area-datetime Issues related to date/time functionality. enhancement New feature or request

Comments

@OrestZborowski-SIG
Copy link
Contributor

It would be useful to support the Sydney timezone.

@OrestZborowski-SIG OrestZborowski-SIG added the enhancement New feature or request label Dec 6, 2021
@jack-pappas
Copy link
Collaborator

If you add this, please use the proper tz database name for the timezone: Australia/Sydney for easier compatibility with other libraries/tools.

Ideally, riptable should get rid of the hard-coded timezone information it's maintaining. Instead, it should take a reference on the tzdata package via conda or pip; that package is already a requirement for many other Python libraries, so most users should already have it available in their Python environments. The timezone offset data for all timezones in the tz database can be supported by parsing the timezone offset information from tzdata using the logic from the built-in zoneinfo module in CPython: https://github.com/python/cpython/blob/1c7a1c3be08ee911d347fffd2716f3911ba751f9/Lib/zoneinfo/_zoneinfo.py

Some of the supporting logic from zoneinfo, e.g. converting timestamps between UTC and local time could then just be ported over + adapted to array-style programming, e.g. using rt.searchsorted(..., side='right') instead of bisect.bisect_right(...). Some hypothesis-based tests could be implemented to verify the accuracy of the conversions too, by checking the array-based results against an equivalent list of dt.date / dt.datetime run through the corresponding function from datetime or zoneinfo.

@jack-pappas jack-pappas added the area-datetime Issues related to date/time functionality. label Dec 7, 2021
OrestZborowski-SIG pushed a commit that referenced this issue Aug 23, 2022
Improve test run scripts (#314)

Improve the run scripts so they will propagate exit codes. This allows them to break the build if tests fail.
Disable the tooling integration tests since they actually fail, and will now fail the builds. This will need to be remedied (issue #313).
Expose operator methods on FastArray

Fixes issues in #240

Ignore test dirs for autodoc
Fix is so that filtered elements still show the count of non-filtered elements for their group

Add Replace methods to FAString

Fix median kwargs

Fixes issues in categorical comparisons for example those in #256

Fix str mean crashes

Adds a Sydney Time Zone addressing #265.

Check count filter length
Fixes #291

Adds a statx method for fastarrays.

Fixes ufunc2 custom out test due to np122 changes

Support numpy<1.23

Allows multiple arguments in col_filter

Replace eq = __eq__ with def eq(self,other): return self.__eq__(other)

Fix check for fixed size binary conversion

Update Dataset docstrings: head, tail, sample, describe

Add YAML and shell script specializations

Fixed formatting errors (except duplicate obj descs)

Update riptable GH CI for numpy122

Tighten dependencies

Update dependency constraints

Fixed formatting errors in rt_timezone and rt_utils

Fixed formatting errors in rt_struct

Fixed formatting errors in rt_str

Fixed formatting errors in rt_pgroupby and rt_sds

Fixed formatting errors in rt_pdataset

Fixed formatting errors in rt_multiset

Fixed formatting errors in rt_misc

Fixed formatting errors in rt_meta

Fixed formatting errors in rt_merge

Fixed formatting errors in rt_groupbykeys

Fixed formatting errors in rt_itemcontainer

Fix docstring for regex_replace

Update setup.py dependencies

Support the 'Australia/Sydney' timezone.

Fix formatting errors and update math methods

Fixed Sphinx formatting errors in rt_appdirs

Fixed short underline in benchmarking.rst

Add set_valid method; identical to filter

Fix Categorical Where
OrestZborowski-SIG added a commit that referenced this issue Aug 23, 2022
* Latest changes

Improve test run scripts (#314)

Improve the run scripts so they will propagate exit codes. This allows them to break the build if tests fail.
Disable the tooling integration tests since they actually fail, and will now fail the builds. This will need to be remedied (issue #313).
Expose operator methods on FastArray

Fixes issues in #240

Ignore test dirs for autodoc
Fix is so that filtered elements still show the count of non-filtered elements for their group

Add Replace methods to FAString

Fix median kwargs

Fixes issues in categorical comparisons for example those in #256

Fix str mean crashes

Adds a Sydney Time Zone addressing #265.

Check count filter length
Fixes #291

Adds a statx method for fastarrays.

Fixes ufunc2 custom out test due to np122 changes

Support numpy<1.23

Allows multiple arguments in col_filter

Replace eq = __eq__ with def eq(self,other): return self.__eq__(other)

Fix check for fixed size binary conversion

Update Dataset docstrings: head, tail, sample, describe

Add YAML and shell script specializations

Fixed formatting errors (except duplicate obj descs)

Update riptable GH CI for numpy122

Tighten dependencies

Update dependency constraints

Fixed formatting errors in rt_timezone and rt_utils

Fixed formatting errors in rt_struct

Fixed formatting errors in rt_str

Fixed formatting errors in rt_pgroupby and rt_sds

Fixed formatting errors in rt_pdataset

Fixed formatting errors in rt_multiset

Fixed formatting errors in rt_misc

Fixed formatting errors in rt_meta

Fixed formatting errors in rt_merge

Fixed formatting errors in rt_groupbykeys

Fixed formatting errors in rt_itemcontainer

Fix docstring for regex_replace

Update setup.py dependencies

Support the 'Australia/Sydney' timezone.

Fix formatting errors and update math methods

Fixed Sphinx formatting errors in rt_appdirs

Fixed short underline in benchmarking.rst

Add set_valid method; identical to filter

Fix Categorical Where

* Enable magical preserve_egg_dir

Co-authored-by: rtosholdings-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-datetime Issues related to date/time functionality. enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants