You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Applying Dataset.putmask on a dataset with different columns, or with the same columns but in a different order, will silently produce garbage.
The issue happens because Dataset.putmask(mask, values) just validates that self.shape == values.shape, and then it operated on the columns by index and not by name.
Here is a realistic example (rt.merge_lookup puts the 'on' columns first, which causes the issue):
Applying Dataset.putmask on a dataset with different columns, or with the same columns but in a different order, will silently produce garbage.
The issue happens because Dataset.putmask(mask, values) just validates that self.shape == values.shape, and then it operated on the columns by index and not by name.
Here is a realistic example (rt.merge_lookup puts the 'on' columns first, which causes the issue):
The text was updated successfully, but these errors were encountered: