-
-
Notifications
You must be signed in to change notification settings - Fork 886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React 19 support #877
Comments
This comment has been minimized.
This comment has been minimized.
@wooorm If I upgrade to React 19 in this repo and
In syntax-tree/hast-util-to-jsx-runtime@ae638ba you provide the solution of declaring a global JSX namespace. Would you recommend doing that here? |
I tried the global JSX namespace suggestion import type { JSX as Jsx } from "react/jsx-runtime";
declare global {
namespace JSX {
type ElementClass = Jsx.ElementClass;
type Element = Jsx.Element;
type IntrinsicElements = Jsx.IntrinsicElements;
}
} ... but it doesn't seem to make a difference for the error I'm getting with React 19:
|
Actually, this suggestion worked for me. Upgraded to Next.js 15 and React 19 without errors. |
This comment has been minimized.
This comment has been minimized.
Well, what I would recommend doing is speaking to the people that made this change: it’s not a bad change on its own, but it is a very useful feature and there is no alternative, plus this change means that millions of people need to change too. It’s just a lot of work. Not just for us here. |
Thanks for getting this merged! Is there a plan to cut a new release? |
Followup to #871
react-markdown
relies onJSX
being in the global namespace, which has been removed in@types/react^19
.Per @ChristianMurphy here:
React 19 is now GA, so this issue is to track.
The text was updated successfully, but these errors were encountered: