Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add isRequired to prop types #117

Open
nickserv opened this issue Dec 16, 2019 · 0 comments
Open

Add isRequired to prop types #117

nickserv opened this issue Dec 16, 2019 · 0 comments
Labels
internal This change is not user facing

Comments

@nickserv
Copy link
Member

Our prop types aren't using isRequired. This means that all prop types are optional, which could lead to bugs with missing props.
@nickserv nickserv added the internal This change is not user facing label Dec 16, 2019
@nickserv nickserv changed the title Add isRequired to PropTypes Add isRequired to prop types Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
internal This change is not user facing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nickserv