Skip to content
This repository has been archived by the owner on Jun 6, 2022. It is now read-only.

macOS : Don't duplicate VPN connections #34

Open
pocc opened this issue Jun 5, 2018 · 3 comments
Open

macOS : Don't duplicate VPN connections #34

pocc opened this issue Jun 5, 2018 · 3 comments
Labels
branch Converted to branch bug Something isn't working (PATCH) macos This pertains only to macOS
Milestone

Comments

@pocc
Copy link
Owner

pocc commented Jun 5, 2018

macOS : Don't duplicate VPN connections

Problem Statement

scutil and networksetup will fail if there are multiple VPN connections with the same name.

Proposed Solution

  • If there is a VPN with the planned VPN name, don't create a new one
  • If there are multiple VPN connections with the same name, throw an error and quit to main menu
  • Otherwise create the VPN connection
@pocc pocc added the bug Something isn't working (PATCH) label Jun 5, 2018
@pocc pocc added this to the Finish UI features milestone Jun 5, 2018
@pocc pocc self-assigned this Jun 5, 2018
@pocc pocc modified the milestones: Finish UI features, Ship MVP Jun 5, 2018
@pocc pocc added the macos This pertains only to macOS label Jun 5, 2018
pocc added a commit that referenced this issue Jun 25, 2018
@pocc
Copy link
Owner Author

pocc commented Jul 7, 2018

Instead of denying the connection creation, do connection-name-1

@pocc
Copy link
Owner Author

pocc commented Jul 7, 2018

@pocc pocc added the branch Converted to branch label Jul 8, 2018
@pocc
Copy link
Owner Author

pocc commented Jul 8, 2018

It may be worthwhile to verify that macos connections work at all (and whether they broke at some point in the past).

Pasting the python directly into the terminal gives us this error:
0:254: execution error: No service (1)

It's likely something related to osascript

@pocc pocc mentioned this issue Sep 7, 2018
1 task
@pocc pocc removed their assignment Sep 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
branch Converted to branch bug Something isn't working (PATCH) macos This pertains only to macOS
Projects
None yet
Development

No branches or pull requests

1 participant