Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include containing type's visibility on visibility check #118

Open
paul-bennett opened this issue May 5, 2024 · 0 comments
Open

Include containing type's visibility on visibility check #118

paul-bennett opened this issue May 5, 2024 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@paul-bennett
Copy link
Owner

Sometimes Juggle will emit matches for methods (and presumably fields and types) that don't show up in the JavaDoc. For example, output for the query $ juggle '? compare' includes the compare method of the nested java.util.Collections.ReverseComparator class.

Because ReverseComparator has package accessibility, Juggle shouldn't include this match in its output.

When checking visibility of a member, field or class, Juggle should also recursively check the visibility of containing types.

@paul-bennett paul-bennett added bug Something isn't working good first issue Good for newcomers labels May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant