Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DescriptionList - heading level and heading element invalid in examples #11393

Open
thatblindgeye opened this issue Jan 8, 2025 · 0 comments

Comments

@thatblindgeye
Copy link
Contributor

thatblindgeye commented Jan 8, 2025

Describe the problem
This ranges from example code update to component update:

  • For the Popover that triggers when clicking the term help text, the heading level is not correct for where it is rendered in the DOM. Either the heading should be an h1 element, or the Popover needs to be appended in a way that the current h6 is correct.
  • For the Popover that triggers when clicking the term help text, axe complains about multiple banner landmarks. This is due to the Popover being appended to the document body and outside the main element; whenever a header is rendered outside of it, it becomes a banner landmark. Some ways to fix this could be:
    • update the element to a plain div
    • change where the Popover is appended (could also help resolve the first issue above)
    • since the Popover traps focus and has attributes similar to a Modal, all other content on the page gets set to aria-hidden="true", similar behavior to the Modal component. This might be an issue since we don't render a Backdrop for Popover like we do for Modal, though, so it may not be totally clear that content outside the Popover cannot be interacted with. Also, unlike Modal, you can click outside the Popover to close it, which may not make the aria-modal="true" attribute totally correct.

How do you reproduce the problem?
Provide steps to reproduce. A codesandbox demonstrating the problem is appreciated.

Expected behavior
A clear and concise description of the expected behavior.

Is this issue blocking you?
List the workaround if there is one.

Screenshots
If applicable, add screenshots to help explain the issue.

What is your environment?

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

What is your product and what release date are you targeting?

Any other information?

@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Jan 8, 2025
@thatblindgeye thatblindgeye moved this from Needs triage to Backlog in PatternFly Issues Jan 23, 2025
@thatblindgeye thatblindgeye changed the title Bug - DescriptionList - accessibility issues with term help text examples/implementation DescriptionList - heading level and heading element invalid in examples Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

1 participant