Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disk size validation hiccup when creating from a 1023 GiB disk snapshot #2640

Open
askfongjojo opened this issue Jan 8, 2025 · 2 comments · May be fixed by #2641
Open

Disk size validation hiccup when creating from a 1023 GiB disk snapshot #2640

askfongjojo opened this issue Jan 8, 2025 · 2 comments · May be fixed by #2641
Assignees
@david-crespo
Milestone
13

Comments

@askfongjojo
Copy link

I created a blank disk with a size of 1023 GiB then took a snapshot of it with the intention of making new disks from the snapshot.

When trying to make a new disk out of the snapshot and set it to the same size, I got this error
Image

To work around the weird error above, I made it smaller and got the following error (not a bug - it's a valid error):
Image

Afterwards, I was able to put it back to 1023 GiB and the UI gladly accepted the value and created the disk for me:
Image
@david-crespo
Copy link
Collaborator

The validation logic seems to be in order, so I’m thinking maybe the internal state and the field are of our sync, so the diskSizeGiB it’s validating is not 1023.

console/app/components/form/fields/DiskSizeField.tsx

Lines 53 to 55 in c2ea0e3

if (diskSizeGiB > MAX_DISK_SIZE_GiB) {
return `Can be at most ${MAX_DISK_SIZE_GiB} GiB`
}

Should be easy to repro.

@david-crespo david-crespo self-assigned this Jan 9, 2025
@david-crespo david-crespo added this to the 13 milestone Jan 9, 2025
@david-crespo
Copy link
Collaborator

WELP

Image

@david-crespo david-crespo linked a pull request Jan 9, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@david-crespo david-crespo

Labels
None yet
Projects
None yet
Milestone
13
Development

Successfully merging a pull request may close this issue.

Fix size validation on disk create from 1023 GiB snapshot oxidecomputer/console
2 participants
@david-crespo @askfongjojo