Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarification needed in RegEx guide #548

Open
ctcpip opened this issue Jun 21, 2024 · 3 comments
Open

clarification needed in RegEx guide #548

ctcpip opened this issue Jun 21, 2024 · 3 comments

Comments

@ctcpip
Copy link
Member

ctcpip commented Jun 21, 2024

in https://github.com/ossf/wg-best-practices-os-developers/blob/main/docs/Correctly-Using-Regular-Expressions.md, the following text appears in the Java row: “\z”; “$” works but some documents conflict

What does this mean exactly? Let's add some information/context to this in the guide. Alternately, remove the qualification ("but...") if it's not needed. My understanding is that Java $ will only match the end of the input (when not in multiline mode; equivalent to \z) and is therefore safe to use.

cc @david-a-wheeler

@david-a-wheeler
Copy link
Contributor

The "Rationale" goes into detail. Some Oracle documentation directly conflicts with what actually happens.

@gkunz
Copy link
Contributor

gkunz commented Dec 3, 2024

In this case, I suggest to add a "see rationale" to the table. Let's make it easy for readers to find the right information.

david-a-wheeler added a commit that referenced this issue Dec 3, 2024
@david-a-wheeler
Copy link
Contributor

I've created a PR proposing to address this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants