Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: code review score should exclude automated dependency updates #4500

Open
monperrus opened this issue Jan 23, 2025 · 0 comments
Open

BUG: code review score should exclude automated dependency updates #4500

monperrus opened this issue Jan 23, 2025 · 0 comments
Labels
kind/bug Something isn't working

Comments

@monperrus
Copy link

Description

It's a good practice to have dependency bots (Dependabot, Renovate). Today, it's often thee case that there are more dependency PRs than human made commits. With strong testing, it's a good to automerge dependency updates.

Assume you have 30 commits in a release, incl. 1 with code review and 29 bot updates.

Expected behavior

  • Exclude bot PRs
  • Code review score: 0/10

Actual behavior

  • Include all PRs, regardless of content
  • Code review score: 10/10

Additional context

See for example https://deps.dev/maven/fr.inria.gforge.spoon%3Aspoon-core/11.1.1-beta-23

@monperrus monperrus added the kind/bug Something isn't working label Jan 23, 2025
@monperrus monperrus changed the title BUG: code review should exclude automated dependency updates BUG: code review score should exclude automated dependency updates Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

1 participant