Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openvpn: DCO not enabled on snapshot #22472

Open
asdfjkluiop opened this issue Oct 22, 2023 · 9 comments · May be fixed by #25645
Open

openvpn: DCO not enabled on snapshot #22472

asdfjkluiop opened this issue Oct 22, 2023 · 9 comments · May be fixed by #25645

Comments

@asdfjkluiop
Copy link

DCO not enabled on OpenWRT snapshot

Maintainer: @AuthorReflex
Environment: amd64 snapshot build r24162-65380dc41c

Description:
As far as I can tell PR #21547 should've added DCO support but it doesn't seem to be present. I spent a bit of time trying to get DCO working to no avail and then realized when I run openvpn --version it does not show the [DCO] feature flag like it should. As far as I can tell the openvpn userspace program is not being build with DCO enabled, at least on amd64 builds.

@brada4
Copy link

brada4 commented Oct 22, 2023

You need to build package enabling dco option in menuconfig. note no such option is available for 23.05

@asdfjkluiop
Copy link
Author

Well I figured I could build it from source if I wanted to but it seems odd to ship a binary kmod as an official package but then not ship a user space binary which can use it which is why I opened the issue.

@brada4
Copy link

brada4 commented Oct 22, 2023

build it and benchmark it on average mips if possible vs non-dco version. 10x speedup looks mpre like marketing pitch/

Sarcasm not welcome, you literarily request removal of dco kmod.

@asdfjkluiop
Copy link
Author

asdfjkluiop commented Oct 22, 2023

I don't have a mips router as my build information in the original issue states. Also I wasn't being sarcastic? That was a genuine statement, without both packages the kmod is useless. I figured that was a mistake since there is PR enabling it but it wasn't enabled in actual builds. Additionally I have benchmarked it on amd64 and it provides quite a large performance increase, maybe it's not as noticeable on mips but I have no way of testing that.

@brada4
Copy link

brada4 commented Oct 22, 2023

Build ipk and validate support. Extensive testing needs mips and aarch having significant improvement to make essentially bigger package default.

@asdfjkluiop
Copy link
Author

If package size is an issue then what about adding a separate dco enabled package that way users could still use it without causing a size increase for storage constrained platforms.

@brada4
Copy link

brada4 commented Oct 23, 2023

The burden of proof and PR is on you.

@asdfjkluiop
Copy link
Author

This is clearly not a productive conversation. I will wait till one of the actual maintainers replies since I'm not looking to submit a PR, this is simply an issue report about a missing feature. I'm not an OpenWRT contributor and based on PR history neither are you and I'm rather tired of your attitude.

@meehien
Copy link

meehien commented Oct 25, 2023

I would also like to have a DCO enabled package for openvpn. I aggree with @asdfjkluiop as it stands now, the kmod is useless and I would add misleading, especially based on its description.

@BKPepe BKPepe linked a pull request Jan 9, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants